Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration option to default to tile view for remote source is not respected #782

Closed
gep13 opened this issue Jun 17, 2020 · 1 comment · Fixed by #783
Closed

Configuration option to default to tile view for remote source is not respected #782

gep13 opened this issue Jun 17, 2020 · 1 comment · Fixed by #783
Assignees
@gep13
Labels
Bug Issues where something has happened which was not expected or intended
Milestone
0.18.0

Comments

@gep13
Copy link
Member

gep13 commented Jun 17, 2020

When initially setting up the remote source view, it should be looking at the DefaultToTileViewForRemoteSource configuration property, however, it is looking at the DefaultToTileViewForLocalSource instead. It is using the DefaultToTileViewForRemoteSource property when a change has been initiated from the Settings screen, but not on initial configuration.
@gep13 gep13 added the Bug Issues where something has happened which was not expected or intended label Jun 17, 2020
@gep13 gep13 added this to the 0.18.0 milestone Jun 17, 2020
@gep13 gep13 self-assigned this Jun 17, 2020
gep13 added a commit that referenced this issue Jun 17, 2020
@gep13
(GH-782) Ensure correct property is used
7e71fc4 
When setting up the RemoteSourceViewModel, the DefaultToTileViewForLocalSource was
being used, where the DefaultToTileViewForRemoteSource used be getting used instead.
@gep13 gep13 mentioned this issue Jun 17, 2020
Merged
gep13 added a commit that referenced this issue Jun 17, 2020
@gep13
(GH-782) Ensure correct property is used
a6e6eb4 
When setting up the RemoteSourceViewModel, the DefaultToTileViewForLocalSource was
being used, where the DefaultToTileViewForRemoteSource used be getting used instead.
gep13 added a commit that referenced this issue Jun 17, 2020
@gep13
Merge pull request #783 from chocolatey/feature/GH-782
ffa1341 
(GH-782) Ensure correct property is used
choco-bot pushed a commit that referenced this issue Jun 17, 2020
@web-flow
Continuous Integration Publish: ffa1341
35abb54 
Merge pull request #783 from chocolatey/feature/GH-782

(GH-782) Ensure correct property is used
@gep13 gep13 changed the title DefaultToTileViewForRemoteSource isn't used properly The configuration option to default to tile view for remove source is not respected Mar 8, 2021
@gep13 gep13 changed the title The configuration option to default to tile view for remove source is not respected Configuration option to default to tile view for remove source is not respected Mar 8, 2021
@gep13 gep13 changed the title Configuration option to default to tile view for remove source is not respected Configuration option to default to tile view for remote source is not respected Mar 8, 2021
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.18.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

(GH-782) Ensure correct property is used chocolatey/ChocolateyGUI
2 participants
@gep13 @choco-bot