Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to allow controlling whether This PC tab is shown or not #884

Closed
gep13 opened this issue Sep 6, 2021 · 1 comment
Closed

Add feature to allow controlling whether This PC tab is shown or not #884

gep13 opened this issue Sep 6, 2021 · 1 comment
Labels
Improvement Issues that enhances existing functionality, or adds new features NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product
Milestone
0.19.0

Comments

@gep13
Copy link
Member

gep13 commented Sep 6, 2021

NOTE: This will be a feature of Chocolatey GUI Licensed Extension

This will actually be implemented in the Chocolatey GUI Licensed Extension here:

chocolatey/chocolatey-licensed-issues#228

But the feature needs to be created in Chocolatey GUI OSS, so that it can be toggled on/off
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label Sep 6, 2021
@gep13 gep13 added this to the 0.19.0 milestone Sep 6, 2021
gep13 added a commit that referenced this issue Sep 6, 2021
@gep13
(#884) Add feature toggle for This PC source
1eed0a7 
There is no actual functionality change here, all we are doing is
adding a new feature to Chocolatey GUI, which can be picked up in the
Chocolatey GUI Licensed Extension, to then actually show/hide the This
PC source when this feature is enabled.
gep13 added a commit that referenced this issue Sep 6, 2021
@gep13
(#884) Add feature toggle for Update All button
3f3e743 
There is no actual functionality change here, all we are doing is
adding a new feature to Chocolatey GUI, which can be picked up in the
Chocolatey GUI Licensed Extension, to then actually show/hide the
Update All button, based on whether this feature is enabled/disabled.
gep13 added a commit that referenced this issue Sep 6, 2021
@gep13
(#883 #884) Add package parameters for features
dc00ce9 
To provide information about how these features can be toggled on/off
during the installation of the Chocolatey GUI package.
@gep13 gep13 added the NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product label Sep 6, 2021
@gep13 gep13 closed this as completed Sep 6, 2021
@gep13 gep13 added NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product and removed NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product labels Sep 6, 2021
gep13 added a commit that referenced this issue Sep 6, 2021
@gep13
Merge branch 'release/0.19.0'
03ce669 
* release/0.19.0:
  (#882) Make use of OSS Export Command
  (#883 #884) Add package parameters for features
  (#884) Add feature toggle for Update All button
  (#884) Add feature toggle for This PC source
  (#881) Add IsUpgradeAllCommandAllowed to interface
  (#882) Use latest chocolatey.lib nuget package
  (#869) Update to use latest version of log4net
  (#882) Bump chocolatey dependency
gep13 added a commit that referenced this issue Sep 6, 2021
@gep13
Merge branch 'release/0.19.0' into develop
a741449 
* release/0.19.0:
  (maint) Reduce description to below 4000 chars
  (#882) Make use of OSS Export Command
  (#883 #884) Add package parameters for features
  (#884) Add feature toggle for Update All button
  (#884) Add feature toggle for This PC source
  (#881) Add IsUpgradeAllCommandAllowed to interface
  (#882) Use latest chocolatey.lib nuget package
  (#869) Update to use latest version of log4net
  (#882) Bump chocolatey dependency
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.19.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@ryanrichter94 ryanrichter94 mentioned this issue Jun 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Issues that enhances existing functionality, or adds new features NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product
Projects
None yet
Milestone
0.19.0
Development

No branches or pull requests
2 participants
@gep13 @choco-bot