Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version ranges in nuspec file to use maximum inclusive rather than maximum exclusive #999

Closed
4 tasks done
gep13 opened this issue May 9, 2023 · 2 comments
Closed
4 tasks done

Update version ranges in nuspec file to use maximum inclusive rather than maximum exclusive #999

gep13 opened this issue May 9, 2023 · 2 comments
Assignees
@gep13
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Milestone
1.1.3

Comments

@gep13
Copy link
Member

gep13 commented May 9, 2023

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my problem.
  • I have verified this is not an issue for a specific package.
  • I have verified this issue is not security related.

What You Are Seeing?

When attempting to upgrade to the latest stable package versions for the 2.x/6.x release of the Chocolatey products, there are issues with resolving package dependencies. This is due in part to a bug in the NuGet.Core assemblies with regard to how maximum exclusive/inclusive versions are handled.

Currently, for Chocolatey GUI, we use the following:

      <dependency id="Chocolatey" version="[1.0.0, 2.0.0)" />

This can cause problems for example when you attempt to upgrade to a pre-release 2.0.0 package version, compared to a stable 2.0.0 package version.

To avoid any ambiguity, and prevent confusion going forward, the suggestion is to switch to:

      <dependency id="Chocolatey" version="[1.0.0, 1.999.999]" />

That way, the cross over to the 2.0.0 release is clear, and should no longer impact on dependency resolution that is performed.

A similar change has already been made to the version ranges in the upcoming 2.x and 6.x releases.

What is Expected?

There should be no dependency resolution problems when attempting to perform choco upgrade chocolatey when a major version range is being crossed.

How Did You Get This To Happen?

An attempt was made to upgrade to the latest stable package version for all of the Chocolatey products, i.e. 2.x.

System Details

  • Operating System: Windows 10
  • Windows PowerShell version: 5.1.19041.2364
  • Chocolatey CLI Version: 1.3.1
  • Chocolatey Licensed Extension version: 5.0.2
  • Chocolatey License type: Business
  • Terminal/Emulator: PowerShell

Installed Packages

N/A

Output Log

N/A

Additional Context

N/A
@gep13 gep13 added Bug Issues where something has happened which was not expected or intended 2 - Working A user or team member has started working on the issue labels May 9, 2023
@gep13 gep13 added this to the 1.1.3 milestone May 9, 2023
@gep13 gep13 self-assigned this May 9, 2023
gep13 added a commit that referenced this issue May 10, 2023
@gep13
(#999) Switch to using inclusive maximum version
29980d0 
We found that there were issues when using the exclusive maximum
version when it comes to having stable and pre-release package
versions, so the decision was taken to remove this variable by using a
very high package version number as the upper bound.  That way, when
the cross over between the major version happens, there will be no
conflict.

This commit simply changes the upper bound on the version range to use
the inclusive maximum version, ], rather than the exclusive one, ).
@gep13 gep13 added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 2 - Working A user or team member has started working on the issue labels May 10, 2023
@gep13 gep13 closed this as completed May 10, 2023
gep13 added a commit that referenced this issue May 10, 2023
@gep13
Merge branch 'hotfix/1.1.3' into support/1.x
48a4494 
* hotfix/1.1.3:
  (#999) Switch to using inclusive maximum version
@gep13 gep13 added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels May 10, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 1.1.3 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@abdoughliss
Copy link

abdoughliss commented Dec 13, 2023 •
edited
Loading

Hi , I have a question regarding the Advanced installation option in the installation process. Is there a way to view detailed information about all versions, specifically all the version prior to the last update? Is it possible to choose and download a specific version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
1.1.3
Development

No branches or pull requests
3 participants
@gep13 @choco-bot @abdoughliss