(#904) Wrap MessageBoxes with a hidden window #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corbob
force-pushed
the
904_fix_message_boxes
branch
from
8f04765 to
cbee966
Compare
gep13
added
Bug
gep13
requested changes
Jan 17, 2022
Source/ChocolateyGui.Common.Windows/Utilities/ChocolateyMessageBox.cs
Outdated
Show resolved
Hide resolved
|
@corbob Is this something that you are in a position to get updated? This is slated to go out with 0.20.0. Thanks |
corbob
force-pushed
the
904_fix_message_boxes
branch
from
07ee3d8 to
8bfd269
Compare
gep13
force-pushed
the
904_fix_message_boxes
branch
from
8bfd269 to
31cf539
Compare
There appears to be a "feature" in WPF that prevents MessageBoxes from displaying when there are no active windows. Many of our MessageBoxes are to report errors, and many of them occur during startup. This results in them not displaying as we haven't created any windows. This works around that by creating a hidden window and closing it after the MessageBox has been displayed.
gep13
force-pushed
the
904_fix_message_boxes
branch
from
31cf539 to
4475b74
Compare
|
@corbob thanks for getting this added! This was a great find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a "feature" in WPF that prevents MessageBoxes from
displaying when there are no active windows. Many of our MessageBoxes
are to report errors, and many of them occur during startup. This
results in them not displaying as we haven't created any windows. This
works around that by creating a hidden window and closing it after the
MessageBox has been displayed.
Description Of Changes
Wrap message boxes with calls to display a hidden window.
Motivation and Context
There is apparently a "feature" of WPF that prevents message boxes from displaying unless there's a window being displayed.
Testing
Caveat: I have not verified that all 7 message boxes are displayed, merely the one that I was able to reliably reproduce. I also did not verify the overloads that don't have any references (yet). I merely added them so we have them if needed in the future.
Change Types Made
Related Issue
Fixes #904
Change Checklist