Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#79) Simplify local development of choco-theme #80

Merged
merged 1 commit into from
May 10, 2024

Conversation

st3phhays
Copy link
Member

Description Of Changes

The changes here and the upgrade of choco-theme
are needed in order to utilize new commands that
will help the development of choco-theme.

More information on changes can be found at:
https://github.com/chocolatey/choco-theme/releases/tag/0.7.0

Motivation and Context

This will enhance the developer experience of choco-theme.

Testing

Follow instructions at chocolatey/choco-theme#403.

Change Types Made

  • Minor fix (typos etc.).
  • Major change (refactoring post, refactoring code, reformatting etc.).
  • New post added.
  • Site code change

Change Checklist

Related Issue

@st3phhays
Copy link
Member Author

This is in draft because choco-theme needs updated first, and this PR also needs merged chocolatey/Chocolatey.Docs.Cake.Recipe#15. The Cake version used here will need to be updated.

@st3phhays st3phhays force-pushed the testing-and-development branch from 55b1c2b to 3b21d52 Compare April 29, 2024 19:39
@st3phhays st3phhays self-assigned this Apr 30, 2024
@st3phhays st3phhays force-pushed the testing-and-development branch from 3b21d52 to 53ecd1c Compare May 9, 2024 19:40
The changes here and the upgrade of choco-theme
are needed in order to utilize new commands that
will help the development of choco-theme.

More information on changes can be found at:
https://github.com/chocolatey/choco-theme/releases/tag/0.7.0
@st3phhays st3phhays force-pushed the testing-and-development branch from 53ecd1c to 131cb67 Compare May 9, 2024 19:57
@st3phhays st3phhays requested review from gep13 and vexx32 May 9, 2024 19:59
@st3phhays st3phhays marked this pull request as ready for review May 9, 2024 20:04
@st3phhays
Copy link
Member Author

@vexx32 This PR can be merged without the updates to the Cake script that I have an open PR for chocolatey/Chocolatey.Docs.Cake.Recipe#15. The changes here will not "break" the build, I just won't be able to run the yarn preview --boxstarter command until the above PR is merged.

@gep13 This will require a new version of Cake.

@vexx32 vexx32 merged commit b504a69 into chocolatey:master May 10, 2024
3 checks passed
choco-bot pushed a commit that referenced this pull request May 10, 2024
Merge pull request #80 from st3phhays/testing-and-development

(#79) Simplify local development of choco-theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants