Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrapping Boxstarter fails due to Chocolatey directory already existing #548

Closed
5 tasks done
AdmiringWorm opened this issue Oct 5, 2023 · 1 comment · Fixed by #549
Closed
5 tasks done

Bootstrapping Boxstarter fails due to Chocolatey directory already existing #548

AdmiringWorm opened this issue Oct 5, 2023 · 1 comment · Fixed by #549
Assignees
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended Priority_HIGH Issues that are considered to be a high priority to get fixed
Milestone

Comments

@AdmiringWorm
Copy link
Member

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my problem.
  • I have verified this is not an issue for a specific package.
  • I have verified this issue is not security related.
  • I confirm I am using official, and not unofficial, or modified, Chocolatey products.

What You Are Seeing?

This was reported in the community channels, when bootstrapping boxstarter this fails the the installations due to the Chocolatey directory being created manually by Boxstarter, while an update to the Chocolatey installation will throw an exception if it exists, even when empty.

What is Expected?

We should be able to bootstrap and install Boxstarter in the supported scenarios.

How Did You Get This To Happen?

N/A

System Details

  • Operating System:
  • Windows PowerShell version:
  • Chocolatey CLI Version:
  • Chocolatey Licensed Extension version:
  • Chocolatey License type:
  • Terminal/Emulator:

Will be filled out once more information is available.

Installed Packages

N/A

Output Log

N/A

Additional Context

No response

@AdmiringWorm AdmiringWorm added Bug Issues where something has happened which was not expected or intended 2 - Working A user or team member has started working on the issue Priority_HIGH Issues that are considered to be a high priority to get fixed labels Oct 5, 2023
@AdmiringWorm AdmiringWorm self-assigned this Oct 5, 2023
AdmiringWorm added a commit to AdmiringWorm/boxstarter that referenced this issue Oct 5, 2023
This commit removes the manal creation of the Chocolatey CLI directory
where the application will be installed to.
This is done as a change in the Chocolatey CLI script have changed so
that if the directory exists, Chocolatey CLI will fail to install.

This manual creation may have been needed some time in the past, but has
not been needed for several years now.

We should not create anything that is not needed to be created, and rely
on the installation script instead to know what to set up for its own
installation.
@AdmiringWorm AdmiringWorm added 3 - Review Code has been added, and is available for review as a pull request and removed 2 - Working A user or team member has started working on the issue labels Oct 5, 2023
AdmiringWorm added a commit to AdmiringWorm/boxstarter that referenced this issue Oct 5, 2023
This commit removes the manal creation of the Chocolatey CLI directory
where the application will be installed to.
This is done as a change in the Chocolatey CLI script have changed so
that if the directory exists, Chocolatey CLI will fail to install.

This manual creation may have been needed some time in the past, but has
not been needed for several years now.

We should not create anything that is not needed to be created, and rely
on the installation script instead to know what to set up for its own
installation.
@AdmiringWorm AdmiringWorm added this to the 3.0.3 milestone Oct 6, 2023
@AdmiringWorm AdmiringWorm added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 3 - Review Code has been added, and is available for review as a pull request labels Oct 6, 2023
AdmiringWorm added a commit that referenced this issue Oct 6, 2023
* hotfix/3.0.3:
  (#548) Remove creation of Chocolatey Install Directory
gep13 added a commit to chocolatey/boxstarter.org that referenced this issue Oct 6, 2023
Normally, direct changes to this bootstrapper.ps1 file would not be
made, however, in this instance, we are waiting for the next release of
Boxstarter 3.0.3, and while we are waiting, and to prevent other folks
running into issues with installing Boxstarter, a direct change is
being made.

This is related to this issue:
chocolatey/boxstarter#548

The change here is so that we can get an immediate release of the
bootstrapper script, while we wait for the patch release of the
Boxstarter packages.

At that point, this Bootstrapper script will be updated with the new
package version, which will be 3.0.3.
choco-bot pushed a commit to chocolatey/boxstarter.org that referenced this issue Oct 6, 2023
(maint) Interim update of Bootstrapper script

Normally, direct changes to this bootstrapper.ps1 file would not be
made, however, in this instance, we are waiting for the next release of
Boxstarter 3.0.3, and while we are waiting, and to prevent other folks
running into issues with installing Boxstarter, a direct change is
being made.

This is related to this issue:
chocolatey/boxstarter#548

The change here is so that we can get an immediate release of the
bootstrapper script, while we wait for the patch release of the
Boxstarter packages.

At that point, this Bootstrapper script will be updated with the new
package version, which will be 3.0.3.
@AdmiringWorm AdmiringWorm added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Oct 9, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 3.0.3 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

AdmiringWorm added a commit that referenced this issue Oct 9, 2023
* master:
  (#548) Remove creation of Chocolatey Install Directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended Priority_HIGH Issues that are considered to be a high priority to get fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants