Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to skip file logging for Zip file extraction in the Get-ChocolateyUnZip and Install-ChocolateyZipPackage cmdlets #1332

Closed
njlr opened this issue Jun 12, 2017 · 5 comments · Fixed by #2449
Closed

Add option to skip file logging for Zip file extraction in the Get-ChocolateyUnZip and Install-ChocolateyZipPackage cmdlets #1332

njlr opened this issue Jun 12, 2017 · 5 comments · Fixed by #2449
Assignees
@TheCakeIsNaOH
Labels
5 - Released Improvement IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen Requires Upstream Change Requires changes to a different location once issue is fixed or implemented Up For Grabs
Milestone
1.2.0

Comments

@njlr
Copy link

njlr commented Jun 12, 2017 •
edited by gep13
Loading

Choco times-out for large zip files (9, 500+ files).

Perhaps an option to disable the logging of each file would speed-up the process?

(Admin edit - notes):

Admin edit - Gitter screenshots
The above link to Gitter may disappear as we have transitioned to Discord for chat, so capturing some screenshots of the conversation:

2021-11-13_21-10-51

2021-11-13_21-12-34

2021-11-13_21-13-06

2021-11-13_21-13-32

2021-11-13_21-14-03
@ferventcoder ferventcoder changed the title Switch to not log the files during unzip Install-ChocolateyPackage / Get-ChocolateyUnzip - switch to not log the files during unzip for zips with many files Jun 12, 2017
@ferventcoder ferventcoder added this to the 0.10.9 milestone Jun 12, 2017
@ferventcoder
Copy link
Member

ferventcoder commented Jun 12, 2017 •
edited
Loading

choco/src/chocolatey.resources/helpers/functions/Get-ChocolateyUnzip.ps1

Line 151 in e96fb15

$params = "x -aoa -bd -bb1 -o`"$destinationNoRedirection`" -y `"$fileFullPathNoRedirection`""
is where it sets the log level (currently -bb1). This switch would allow for the log detail to be missing.

This would also remove chocolatey's ability to use Uninstall-ChocolateyZipPackage as it would not be capturing the file list for removal, but if you are just unpacking into the package directory, this is okay anyway as that function is not necessary.

Workaround

Use Get-ChocolateyWebFile to bring down the zip, then take a dependency on 7zip package and use 7zip directly to unpack the files. Here's an example - https://chocolatey.org/packages/Vivaldi/1.9.818.44

@ferventcoder ferventcoder modified the milestones: 0.10.9, 0.10.10 Aug 29, 2017
@ferventcoder ferventcoder modified the milestones: 0.10.10, 0.10.12 Mar 27, 2018
@ferventcoder ferventcoder modified the milestones: 0.10.12, 0.10.13 May 3, 2018
@ferventcoder ferventcoder modified the milestones: 0.10.13, 0.10.14, 0.10.15 Mar 9, 2019
@ferventcoder ferventcoder modified the milestones: 0.10.15, 0.10.16 Apr 1, 2019
@gep13 gep13 modified the milestones: 0.10.16, 0.10.17 May 31, 2019
@ferventcoder ferventcoder modified the milestones: 0.10.17, 0.10.18 Jan 14, 2020
@ferventcoder ferventcoder modified the milestones: 0.10.18, 0.10.x Apr 14, 2021
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Nov 13, 2021
@TheCakeIsNaOH
(chocolatey#1332) Add switch to disable logging for archive extraction
60ab270 
Adds a switch "disableLogging" to Get-ChocolateyUnzip and
Install-ChocolateyZipPackage. This switch disable 7zip logging of
extracted filenames and does not write out the log of extracted
files. Install-ChocolateyZip passes the switch to Get-ChocolateyUnzip,
and the functionality is implemented into Get-ChocolateyUnzip.

This is useful for large archives with a very large number of files as
logging the extracted files can significantly slow down the extraction
process.
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Nov 13, 2021
Merged
8 tasks
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Dec 23, 2021
@TheCakeIsNaOH @gep13
(chocolatey#1332) Add switch to disable logging for archive extraction
8f94f71 
Adds a switch "disableLogging" to Get-ChocolateyUnzip and
Install-ChocolateyZipPackage. This switch disable 7zip logging of
extracted filenames and does not write out the log of extracted
files. Install-ChocolateyZip passes the switch to Get-ChocolateyUnzip,
and the functionality is implemented into Get-ChocolateyUnzip.

This is useful for large archives with a very large number of files as
logging the extracted files can significantly slow down the extraction
process.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jun 27, 2022
@TheCakeIsNaOH
(chocolatey#1332) Add switch to disable logging for archive extraction
b7f368b 
Adds a switch "disableLogging" to Get-ChocolateyUnzip and
Install-ChocolateyZipPackage. This switch disable 7zip logging of
extracted filenames and does not write out the log of extracted
files. Install-ChocolateyZip passes the switch to Get-ChocolateyUnzip,
and the functionality is implemented into Get-ChocolateyUnzip.

This is useful for large archives with a very large number of files as
logging the extracted files can significantly slow down the extraction
process.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jun 27, 2022
@TheCakeIsNaOH
(chocolatey#1332) Add switch to disable logging for archive extraction
eba8a30 
Adds a switch "disableLogging" to Get-ChocolateyUnzip and
Install-ChocolateyZipPackage. This switch disable 7zip logging of
extracted filenames and does not write out the log of extracted
files. Install-ChocolateyZip passes the switch to Get-ChocolateyUnzip,
and the functionality is implemented into Get-ChocolateyUnzip.

This is useful for large archives with a very large number of files as
logging the extracted files can significantly slow down the extraction
process.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Jun 30, 2022
@TheCakeIsNaOH @gep13
(chocolatey#1332) Add switch to disable logging for archive extraction
1050421 
Adds a switch "disableLogging" to Get-ChocolateyUnzip and
Install-ChocolateyZipPackage. This switch disable 7zip logging of
extracted filenames and does not write out the log of extracted
files. Install-ChocolateyZip passes the switch to Get-ChocolateyUnzip,
and the functionality is implemented into Get-ChocolateyUnzip.

This is useful for large archives with a very large number of files as
logging the extracted files can significantly slow down the extraction
process.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jun 30, 2022
@TheCakeIsNaOH
(chocolatey#1332) Add switch to disable logging for archive extraction
d9b7be2 
Adds a switch "disableLogging" to Get-ChocolateyUnzip and
Install-ChocolateyZipPackage. This switch disable 7zip logging of
extracted filenames and does not write out the log of extracted
files. Install-ChocolateyZip passes the switch to Get-ChocolateyUnzip,
and the functionality is implemented into Get-ChocolateyUnzip.

This is useful for large archives with a very large number of files as
logging the extracted files can significantly slow down the extraction
process.
gep13 added a commit that referenced this issue Jul 1, 2022
@gep13
Merge pull request #2449 from TheCakeIsNaOH/unzip-nolog
cce748a 
(#1332) Add switch to disable logging for archive extraction
@gep13 gep13 added 4 - Done and removed 3 - Review labels Jul 1, 2022
@gep13 gep13 modified the milestones: Future, 1.2.0 Jul 1, 2022
@choco-bot choco-bot added Documentation ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added labels Aug 24, 2022
@chocolatey chocolatey deleted a comment from choco-bot Aug 24, 2022
@pauby
Copy link
Member

pauby commented Aug 24, 2022

In the release notes, we should call out that this will not be available in licensed versions until a release of the Licensed extension.

@gep13
Copy link
Member

gep13 commented Aug 25, 2022 •
edited
Loading

A follow up issue for Chocolatey Licensed Extension has been created so that this work can be tracked.

chocolatey/chocolatey-licensed-issues#319

@sync-by-unito sync-by-unito bot mentioned this issue Aug 25, 2022
Closed
1 task
@AdmiringWorm AdmiringWorm mentioned this issue Sep 21, 2022
Merged
10 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Sep 21, 2022
@AdmiringWorm
(chocolatey#1332) Add tests for disabling archive extraction logging
063deee 
This commit adds two new tests for the upcoming
functionality that has been added that allows
maintainers to specify an extra argument when
extracting zip archives to not log out the file
paths that are inside of the archive.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Sep 22, 2022
@AdmiringWorm
(chocolatey#1332) Add tests for disabling archive extraction logging
13968e9 
This commit adds two new tests for the upcoming
functionality that has been added that allows
maintainers to specify an extra argument when
extracting zip archives to not log out the file
paths that are inside of the archive.
corbob added a commit that referenced this issue Sep 22, 2022
@corbob
Merge pull request #2824 from AdmiringWorm/logging-tests
097b52f 
(#1332) Add tests for disabling file logging of archive extractions
@AdmiringWorm AdmiringWorm added IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen and removed ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added labels Sep 22, 2022
@corbob corbob changed the title Install-ChocolateyPackage / Get-ChocolateyUnzip - switch to not log the files during unzip for zips with many files Add option to skip file logging for Zip file extraction in the Get-ChocolateyUnZip and Install-ChocolateyZipPackage cmdlets Sep 23, 2022
@AdmiringWorm
Copy link
Member

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheCakeIsNaOH TheCakeIsNaOH

Labels
5 - Released Improvement IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen Requires Upstream Change Requires changes to a different location once issue is fixed or implemented Up For Grabs
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

(#1332) Add switch to disable logging for archive extraction TheCakeIsNaOH/choco
7 participants
@ferventcoder @gep13 @AdmiringWorm @njlr @choco-bot @pauby @TheCakeIsNaOH