Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about environment changes #563

Closed
ferventcoder opened this issue Jan 21, 2016 · 0 comments
Closed

Warn about environment changes #563

ferventcoder opened this issue Jan 21, 2016 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Improvement Security
Milestone
0.9.10

Comments

@ferventcoder
Copy link
Member

Detect environment variable changes during install, upgrade and
uninstall. Log all of the changes. Do not log the actual environment
variable values by default as they could contain sensitive data.
Instead inform the user about the need to flip a feature if they want
the value changes logged with a warning that it could disclose
sensitive data.

Also provide SET type information if the feature is turned on.

When environment variables have changed, inform the user they need to
take action to see the changes as Windows doesn't automatically update
command shells like PowerShell.exe and cmd.exe. Inform cmd.exe users
that they can simply type a single command to get their environment
updated.
@ferventcoder ferventcoder self-assigned this Jan 21, 2016
@ferventcoder ferventcoder added this to the 0.9.10 milestone Jan 21, 2016
@ferventcoder ferventcoder mentioned this issue Jan 21, 2016
Open
ferventcoder added a commit that referenced this issue Jan 21, 2016
@ferventcoder
(GH-563) Warn/Log Environment Variable Changes
fe640fb 
Detect environment variable changes during install/upgrade and
uninstall. Log all of the changes. Do not log the actual environment
variable values by default as they could contain sensitive data.
Instead inform the user about the need to flip a feature if they want
the value changes logged with a warning that it could disclose
sensitive data.

Also provide SET type information if the feature is turned on.

When environment variables have changed, inform the user they need to
take action to see the changes as Windows doesn't automatically update
command shells like PowerShell.exe and cmd.exe. Inform cmd.exe users
that they can simply type a single command to get their environment
updated.
ferventcoder added a commit that referenced this issue Jan 21, 2016
@ferventcoder
Merge branch 'stable'
37fba78 
* stable:
  (GH-563) Warn/Log Environment Variable Changes
  (GH-565) Escape output when logging external
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jun 9, 2016
@ferventcoder
(chocolateyGH-563) Environment changed message as warning
335bc01 
Ensure it's easy to spot that the environment has changed and the user
should do something.
ferventcoder added a commit that referenced this issue Jun 11, 2016
@ferventcoder
Merge branch 'stable'
69b4ec8 
* stable:
  (GH-715) Report loaded extension in debug
  (GH-455) Adjust summary for unfound sources
  (GH-557) Adjust logging of upgrade messages
  (GH-759) Summarize affected pkgs when at least 5
  (GH-759) One action summary for all actions
  (maint) rename method
  (GH-742) Feature List Formatting
  (maint) licensing updates
  (doc) update generated docs / add download
  (maint) Allow better use of PowershellService
  (GH-781) Web Functions - Return early when local file
  (doc) add more information regarding pro/business
  (GH-563) Environment changed message as warning
  (doc) Uninstall-ChocolateyZipPackage is optional
  (doc) Point to new docs location
  (maint) do not log warning unless regular output
  (GH-519) Update Install-ChocolateyShortcut Docs
  (doc) update generated docs
  (GH-773) Autodoc - Examples Before Parameters
  (GH-774) Autodoc - Fix Aliases
@ferventcoder ferventcoder mentioned this issue Aug 23, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement Security
Projects
None yet
Milestone
0.9.10
Development

No branches or pull requests
2 participants
@ferventcoder @gep13