(GH-2203) Get-ChocolateyUnzip add unzipLocation as an alias to Destination #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Howdy @TheCakeIsNaOH ! This pull request looks fine for code, however the commit needs a bit more. Have you read over the CONTRIBUTING? Even though this isn't much more than adding an alias, the commit message body should have all of the reasoning in it so when we look back in three years (and we do this all the time) we'll understand why the change was made. |
|
Specifically this section - https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md#prepare-commits |
TheCakeIsNaOH
force-pushed
the
add-alias
branch
from
9ad0436 to
5802858
Compare
|
@ferventcoder fixed. |
gep13
requested changes
Feb 25, 2021
src/chocolatey.resources/helpers/functions/Get-ChocolateyUnzip.ps1
Outdated
Show resolved
Hide resolved
TheCakeIsNaOH
force-pushed
the
add-alias
branch
from
5802858 to
f1193c8
Compare
Install-ChocolateyZipPackage already has a Destination alias to UnzipLocation. This adds the inverse case, so Get-ChocolateyUnzip has an alias UnzipLocation to the Destination parameter. The reason for adding this is to reduce frustration from adding the wrong parameter name, and then having to fix it.
|
@TheCakeIsNaOH thanks for getting this added! Once the CI builds are finished we can get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2203