(#2241) Set install location to package dir for portable packages #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCakeIsNaOH
force-pushed
the
portable-install-location
branch
from
87514b8 to
06e666f
Compare
|
@TheCakeIsNaOH can you update this with information about how you have tested this? We are in the process of adding templates to all repositories that would capture this information, but this PR was likely created before we started doing that. Just some information about what packages you have used to verify the execution would be great. Thanks! |
|
@gep13 should this information be added to the pull request, or inside the commit description, or both? |
|
@TheCakeIsNaOH We only need it in the PR description. |
TheCakeIsNaOH
force-pushed
the
portable-install-location
branch
from
06e666f to
3330c46
Compare
TheCakeIsNaOH
force-pushed
the
portable-install-location
branch
from
3330c46 to
8895cd1
Compare
gep13
force-pushed
the
portable-install-location
branch
from
8895cd1 to
068abfa
Compare
Set the install location to the package folder under lib for nuget packages that do not have a chocolateyinstall.ps1. This will display the install location correctly for portable packages that just include binary(s) that get automatically shimmed.
gep13
force-pushed
the
portable-install-location
branch
from
068abfa to
882e3f6
Compare
|
@TheCakeIsNaOH thanks for getting this added! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the install location to the package folder under lib for nuget
packages that do not have a chocolateyinstall.ps1. This will display
the install location correctly for portable packages that just include
binary(s) that get automatically shimmed.
Fixes: #2241
This is definitely up for discussion on the implementation
This might be related to #1370.
This has been tested in a debug build, installing a number of packages, with everything working as expected:
curl,balcon,sumatrapdf.portable,iperf2. These all reported the install location correctly as being inside thelibdirectory. This is the one changed behavior I found, as expected.wget,curl. These all reported the install location as normal inside their respectivetoolsdirectories.4k-video-downloaderThis one still showed the correct install location under "program files"$env:ChocolateyPackageInstallLocation:dolphin-dev,pcsx2-dev. These all displayed the install location as specified in the install script.vcredist140,KB3035131,KB3033929. These all still showed as the installation location being not set.4k-slideshow-makerStill showed the same messagemsi.templateThis one showed as being installed in a subfolder under the templates directory.chocolatey-core.extension,chocolatey-windowsupdate.extension. These showed as being installed in their subfolder under the extensions directory.