Use macOS SD-Card icon instead of the generic one #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. I'll merge and upload a new release as soon as I have some time. Thanks. |
|
Take your time! Thank you very much for your effort in making this kext as best as possible! |
|
I converted it to draft because I'll try to externalize the icon configuration into Info.plist. |
|
I moved back to 'ready'. AFAIK there's no straightforward way to make this work by simply adding it as IOMediaIcon on Info.plist, but it should be done later (e.g. on a refactoring). |
|
I just applied your PR and uploaded a new release. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request sets the same icon used by Apple SD card reader kext for the SDDisk IOService.