Add component.yaml v1.1 configuration section validations #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binoyPeries
requested changes
Jan 8, 2025
| key: yup.string().required(), | ||
| }).nullable().default(null); | ||
|
|
||
| const configGroupRefSchema = yup.object().shape({ |
There was a problem hiding this comment.
What do we need two objects for the same thing?
There was a problem hiding this comment.
Currently, the schemas are identical. However, connection refs and config group refs should be treated separately since there could be independent validations for either of them in coming designs.
binoyPeries
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$subject and respective unit tests
Related task: https://github.com/wso2-enterprise/choreo/issues/32891