This repository has been archived by the owner on Nov 28, 2018. It is now read-only.
(maint) Add testing around exec via Puppet #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on puppetlabs/puppet#5844 being fixed first. |
|
CLA signed by all contributors. |
|
Blocked again on puppetlabs/puppet#5872. |
PE-14681 and MODULES-3125 identified issues running commands via Puppet exec from other service agents. These issues led to PUP-6675: selinux prevents processes from writing to files in /tmp if they don't have a reason to do so. The Puppet service selinux policy appears to exempt this, but other services that invoke Puppet - such as mcollective - aren't configured that way and cause silent exec failures. PUP-6675 fixes this issue. We add an acceptance test to ensure that it doesn't recur in pxp-agent. [skip ci]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PE-14681 and MODULES-3125 identified issues running commands via
Puppet exec from other service agents. These issues led to PUP-6675:
selinux prevents processes from writing to files in /tmp if they
don't have a reason to do so. The Puppet service selinux policy
appears to exempt this, but other services that invoke Puppet - such
as mcollective - aren't configured that way and cause silent exec
failures.
PUP-6675 fixes this issue. We add an acceptance test to ensure that it
doesn't recur in pxp-agent.