feat: Update in-process resolver to support flag metadata open-featur…

…e#1102 Signed-off-by: christian.lutnik <[email protected]>
chrfwow · Jan 2, 2025 · d127cb5 · d127cb5
1 parent bb9767e
commit d127cb5
Show file tree

Hide file tree

Showing 11 changed files with 264 additions and 80 deletions.
diff --git a/providers/flagd/schemas b/providers/flagd/schemas
diff --git a/...main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java b/...main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java
@@ -2,6 +2,7 @@
 
 import static dev.openfeature.contrib.providers.flagd.resolver.process.model.FeatureFlag.EMPTY_TARGETING_STRING;
 
+import java.util.Map;
 import java.util.function.Consumer;
 import java.util.function.Supplier;
 
@@ -39,8 +40,9 @@ public class InProcessResolver implements Resolver {
     private final Consumer<ConnectionEvent> onConnectionEvent;
     private final Operator operator;
     private final long deadline;
-    private final ImmutableMetadata metadata;
+    private final ImmutableMetadata fallBackMetadata;
     private final Supplier<Boolean> connectedSupplier;
+    private final String scope;
 
     /**
      * Resolves flag values using
@@ -54,16 +56,21 @@ public class InProcessResolver implements Resolver {
      *                          connection/stream
      */
     public InProcessResolver(FlagdOptions options, final Supplier<Boolean> connectedSupplier,
-            Consumer<ConnectionEvent> onConnectionEvent) {
+                             Consumer<ConnectionEvent> onConnectionEvent) {
         this.flagStore = new FlagStore(getConnector(options));
         this.deadline = options.getDeadline();
         this.onConnectionEvent = onConnectionEvent;
         this.operator = new Operator();
         this.connectedSupplier = connectedSupplier;
-        this.metadata = options.getSelector() == null ? null
-                : ImmutableMetadata.builder()
-                        .addString("scope", options.getSelector())
-                        .build();
+        if (options.getSelector() == null) {
+            this.scope = null;
+            this.fallBackMetadata = null;
+        } else {
+            this.scope = options.getSelector();
+            this.fallBackMetadata = ImmutableMetadata.builder()
+                    .addString("scope", this.scope)
+                    .build();
+        }
     }
 
     /**
@@ -113,8 +120,11 @@ public void shutdown() throws InterruptedException {
     /**
      * Resolve a boolean flag.
      */
-    public ProviderEvaluation<Boolean> booleanEvaluation(String key, Boolean defaultValue,
-            EvaluationContext ctx) {
+    public ProviderEvaluation<Boolean> booleanEvaluation(
+            String key,
+            Boolean defaultValue,
+            EvaluationContext ctx
+    ) {
         return resolve(Boolean.class, key, ctx);
     }
 
@@ -172,6 +182,7 @@ private <T> ProviderEvaluation<T> resolve(Class<T> type, String key, EvaluationC
             return ProviderEvaluation.<T>builder()
                     .errorMessage("flag: " + key + " not found")
                     .errorCode(ErrorCode.FLAG_NOT_FOUND)
+                    .flagMetadata(fallBackMetadata)
                     .build();
         }
 
@@ -180,6 +191,7 @@ private <T> ProviderEvaluation<T> resolve(Class<T> type, String key, EvaluationC
             return ProviderEvaluation.<T>builder()
                     .errorMessage("flag: " + key + " is disabled")
                     .errorCode(ErrorCode.FLAG_NOT_FOUND)
+                    .flagMetadata(getFlagMetadata(flag))
                     .build();
         }
 
@@ -226,12 +238,51 @@ private <T> ProviderEvaluation<T> resolve(Class<T> type, String key, EvaluationC
             throw new TypeMismatchError(message);
         }
 
-        final ProviderEvaluation.ProviderEvaluationBuilder<T> evaluationBuilder = ProviderEvaluation.<T>builder()
+        return ProviderEvaluation.<T>builder()
                 .value((T) value)
                 .variant(resolvedVariant)
-                .reason(reason);
+                .reason(reason)
+                .flagMetadata(getFlagMetadata(flag))
+                .build();
+    }
+
+    private ImmutableMetadata getFlagMetadata(FeatureFlag flag) {
+        if (flag == null) {
+            return fallBackMetadata;
+        }
+
+        ImmutableMetadata.ImmutableMetadataBuilder metadataBuilder = ImmutableMetadata.builder();
+        if (scope != null) {
+            metadataBuilder.addString("scope", scope);
+        }
+
+        for (Map.Entry<String, Object> entry : flag.getMetadata().entrySet()) {
+            Object value = entry.getValue();
+            if (value instanceof Number) {
+                if (value instanceof Long) {
+                    metadataBuilder.addLong(entry.getKey(), (Long) value);
+                    continue;
+                } else if (value instanceof Double) {
+                    metadataBuilder.addDouble(entry.getKey(), (Double) value);
+                    continue;
+                } else if (value instanceof Integer) {
+                    metadataBuilder.addInteger(entry.getKey(), (Integer) value);
+                    continue;
+                } else if (value instanceof Float) {
+                    metadataBuilder.addFloat(entry.getKey(), (Float) value);
+                    continue;
+                }
+            } else if (value instanceof Boolean) {
+                metadataBuilder.addBoolean(entry.getKey(), (Boolean) value);
+                continue;
+            } else if (value instanceof String) {
+                metadataBuilder.addString(entry.getKey(), (String) value);
+                continue;
+            }
+            throw new IllegalArgumentException("The type of the Metadata entry with key " + entry.getKey()
+                    + " and value " + entry.getValue() + " is not supported");
+        }
 
-        return this.metadata == null ? evaluationBuilder.build()
-                : evaluationBuilder.flagMetadata(this.metadata).build();
+        return metadataBuilder.build();
     }
 }
diff --git a/...main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FeatureFlag.java b/...main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FeatureFlag.java
@@ -25,6 +25,7 @@ public class FeatureFlag {
     private final String defaultVariant;
     private final Map<String, Object> variants;
     private final String targeting;
+    private final Map<String, Object> metadata;
 
     /**
      * Construct a flagd feature flag.
@@ -33,11 +34,14 @@ public class FeatureFlag {
     public FeatureFlag(@JsonProperty("state") String state,
                        @JsonProperty("defaultVariant") String defaultVariant,
                        @JsonProperty("variants") Map<String, Object> variants,
-                       @JsonProperty("targeting") @JsonDeserialize(using = StringSerializer.class) String targeting) {
+                       @JsonProperty("targeting") @JsonDeserialize(using = StringSerializer.class) String targeting,
+                       @JsonProperty("metadata") Map<String, Object> metadata
+    ) {
         this.state = state;
         this.defaultVariant = defaultVariant;
         this.variants = variants;
         this.targeting = targeting;
+        this.metadata = metadata;
     }
 
     /**