Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0 Compatibility #40

Closed
JerikoOne opened this issue Sep 22, 2023 · 14 comments · Fixed by #41
Closed

4.0 Compatibility #40

JerikoOne opened this issue Sep 22, 2023 · 14 comments · Fixed by #41

Comments

@JerikoOne
Copy link

Currently the plugin is not compatible with 4.0 (as of writing this issue: Beta 1):

The API route isn't working
image

The select isn't styled correctly
image

@distantnative
Copy link

distantnative commented Nov 23, 2023

@chrisbeluga To fix you could add the following styles

.navigation-field .k-dropdown-content {
  --button-height: auto;
}

@afbora
Copy link
Contributor

afbora commented Dec 8, 2023

@distantnative Unf, doesn't work.

@afbora
Copy link
Contributor

afbora commented Dec 8, 2023

Also getting alert for K4:

Deprecated: will be removed in a future version. Since Kirby 4.0, you don't need it anymore as wrapper element. Use <k-dropdown-content> as standalone instead.
Deprecated: : align prop will be removed in a future version. Use the alignX prop instead.
Deprecated: : the theme prop will be removed in a future version. For help text, add .k-help " CSS class instead.

@cselex
Copy link

cselex commented Dec 26, 2023

Do we have a new forked maintained version?

@afbora
Copy link
Contributor

afbora commented Dec 26, 2023

Unf not yet.

@lukas-dne
Copy link

lukas-dne commented Jun 1, 2024

I managed to get it to work. Unfortunately I'm not that in into Vuejs and Kirbys plugin structure, so do not 100% understand, WHY it works - but does :D It seemes, that in Kirby 4 the plugin in the current state builds and adds the modal for adding pages to the menu correctly, but the overlay with this modal is not opened.

You have to add three lines of code, so the overlay with the desired overlay will open up:

File: site\plugins\kirby-navigation-main\src\Field.vue
image

Perhaps someone with deeper understanding of Vuejs and Kirbys plugin system can explain, why this works? :)

To fix the dropdown menu, when clicking on "Add", you have to add the following:

File: site\plugins\kirby-navigation-main\src\Field.vue
image

@sachbearbeiter
Copy link
Collaborator

What would have to be done for an "official" Kirby4 compatible version? Does anyone need a small bounty?

@sachbearbeiter
Copy link
Collaborator

FYI We have started to build a proper K4 version.

@lukas-dne
Copy link

Thats good news! :)

@CoderofOne
Copy link

@lukas-dne

What is needed after you add the lines of code? As the dialogs don't pop up for me.

@chrisbeluga
Copy link
Owner

chrisbeluga commented Oct 22, 2024 via email

@sachbearbeiter
Copy link
Collaborator

We have opened a pull request.
#41

@lukas-dne
Copy link

@CoderofOne Hi, I'm afraid I can not help you, because I did not fully understand the implementation. I was only a little bit lucky to get it working ;) But it seemes, that sachbearbeiter is actively working on the k4 ready version of the plugin. This would solve your problem, I suppose.

@sachbearbeiter
Copy link
Collaborator

There are some minor errors in our v4 version, but we will fix it in the next pull request.

@sachbearbeiter sachbearbeiter linked a pull request Nov 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants