Skip to content

Commit

Permalink
autocomplete [nfc]: Fill in some TODO(#...) issue numbers
Browse files Browse the repository at this point in the history
  • Loading branch information
chrisbobbe committed Jul 21, 2023
1 parent 234b65d commit 49a1a4e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions lib/model/autocomplete.dart
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ class MentionAutocompleteView extends ChangeNotifier {
}
}
}
return results; // TODO sort for most relevant first
return results; // TODO(#228) sort for most relevant first
}
}

Expand All @@ -283,8 +283,8 @@ class MentionAutocompleteQuery {
final List<String> _lowercaseWords;

bool testUser(User user, AutocompleteDataCache cache) {
// TODO test email too, not just name
// TODO test with diacritics stripped, where appropriate
// TODO(#236) test email too, not just name
// TODO(#237) test with diacritics stripped, where appropriate

final List<String> nameWords = cache.nameWordsForUser(user);

Expand Down
10 changes: 5 additions & 5 deletions lib/widgets/autocomplete.dart
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ class _ComposeAutocompleteState extends State<ComposeAutocomplete> {
// (maybe handle centrally in `widget.controller`)
replacementString = '${mention(store.users[userId]!, silent: intent.query.silent, users: store.users)} ';
case WildcardMentionAutocompleteResult():
replacementString = '[unimplemented]'; // TODO
replacementString = '[unimplemented]'; // TODO(#234)
case UserGroupMentionAutocompleteResult():
replacementString = '[unimplemented]'; // TODO
replacementString = '[unimplemented]'; // TODO(#233)
}

widget.controller.value = intent.textEditingValue.replaced(
Expand All @@ -110,12 +110,12 @@ class _ComposeAutocompleteState extends State<ComposeAutocomplete> {
String label;
switch (option) {
case UserMentionAutocompleteResult(:var userId):
// TODO avatar
// TODO(#227) avatar
label = PerAccountStoreWidget.of(context).users[userId]!.fullName;
case WildcardMentionAutocompleteResult():
label = '[unimplemented]'; // TODO
label = '[unimplemented]'; // TODO(#234)
case UserGroupMentionAutocompleteResult():
label = '[unimplemented]'; // TODO
label = '[unimplemented]'; // TODO(#233)
}
return InkWell(
onTap: () {
Expand Down

0 comments on commit 49a1a4e

Please sign in to comment.