Skip to content

Commit

Permalink
yarn: Silence warning from a peer-dep in react-intl.
Browse files Browse the repository at this point in the history
Running `yarn` gives the following warning:

  warning " > [email protected]" has unmet peer dependency "prop-types@^15.5.4".

(No such warning if `yarn` stops after step "Resolving packages" and
prints "Already up-to-date"; but if it has any actual work to do, it
always shows this warning in step "Linking dependencies".)

That's the only warning we now routinely get from `yarn`, so let's
get all the way to warning-free.

I believe the proper fix is that this shouldn't be a peer-dependency
in `react-intl` at all; reported that as formatjs/formatjs#1382 .
But as a workaround, adding a direct dependency silences the warning.
  • Loading branch information
gnprice committed Jul 26, 2019
1 parent 02b2df1 commit 5b6014e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@
"prettier": "^1.18.2",
"prettier-eslint": "^9.0.0",
"prettier-eslint-cli": "^5.0.0",
"prop-types": "^15.7.2",
"react-native-cli": "^2.0.1",
"redux-mock-store": "^1.5.1"
},
Expand Down

0 comments on commit 5b6014e

Please sign in to comment.