Handle BaseException in pytest_exception_interact #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using pytest.raises() and the exception is not raised pytest will raise an exception of the Failed class, which inherits from BaseException, not Exception. This would cause an assertion error when recoding the span, which causes pytest to crash
|
Thank you, @ljodal, this change looks fundamentally good, but I think I've got some bitrot in the Github checks here that I'll need to debug, will get back to you soon. |
|
Thanks @ljodal, this is just a bug with pre-commit and isort, nothing on your end. I'll get this sorted out and get a release together this morning. |
|
Awesome, thanks! We've also seen some problems with traces not being flushed, so we have a fix for that as well coming, probably next week. Just in case you want to wait and potentially include that in the release as well :) |
|
Awesome to hear, please keep them coming! I don't mind releasing each update individually, I'll get one out soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using pytest.raises() and the exception is not raised pytest will raise an exception of the Failed class, which inherits from BaseException, not Exception. This would cause an assertion error when recoding the span, which causes pytest to crash