Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refined fixture handling #29

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Refined fixture handling #29

merged 2 commits into from
Oct 1, 2023

Conversation

drcraig
Copy link
Collaborator

@drcraig drcraig commented Sep 30, 2023

@chrisguidry Let me know what you think of this implementation. Should follow pretty much what I was proposing. An example trace looks like
image

@drcraig
Use nodeid instead of name for the span name.
31835e8 
Fixes #27
@drcraig
Capture test function calls distinct from setup and teardown, and ind…
12766e9 
…ividual fixture teardowns.

All fixtures setups and teardowns are included under a test function.
For fixtures scoped higher than a function, their setup is under the
first function that requested them, and teardown under the last function
that did so.

Fixes #28
@drcraig drcraig requested a review from chrisguidry September 30, 2023 10:15
chrisguidry
chrisguidry approved these changes Oct 1, 2023
View reviewed changes
Copy link
Owner

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw heck yeah, this is great! Thanks for the great inline notes. I've started doing this a lot more too as I realized that my worst teammate was me from six months ago. Love the new tests and you're definitely right about using nodeid for the span names.

@chrisguidry chrisguidry merged commit 0cb5a62 into main Oct 1, 2023
@chrisguidry chrisguidry deleted the refined-fixture-handling branch October 1, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisguidry chrisguidry chrisguidry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drcraig @chrisguidry