Add CONTRIBUTING + EditorConfig #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wopian
added
Status: Review Needed
Type: Meta
|
Thanks @wopian. Having a look. |
oldmud0
approved these changes
Feb 15, 2017
|
That bored someone was me :) It wasn't much work actually since I based it
on regular assembly syntax highlighting.
|
|
@chrislgarry 👍❔ Can be added to later with more examples/things to do, but its better than having nothing. 👇 these 2 commits are the last. |
VSCode extension no longer requires manually adding settings
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CONTRIBUTING file which will appear above every new pull request.
It provides some rough guidelines on what to check for in the code, including the outcome of #159 about line breaks.
Additionally it also adds a EditorConfig file to the root, so editing files directly on GitHub will enforce the recommended settings for AGC Assembly.