add bower dependencies to parent project #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| afterInstall: function() { | ||
| var bowerPackages = [ | ||
| { name: 'normalize.css', target: '3.0.3' }, |
There was a problem hiding this comment.
I don't think the addon should pull in normalize. Incorporating it via the addon CSS would affect other things throughout the parent app.
I used it as a quick way to make certain things behave in the ember-freestyle dummy app, but perhaps we should just remove it altogether.
|
Looks great. Will merge after ditching normalize. |
andrewfan
force-pushed
the
create-blueprints
branch
from
afd12be to
0f1ae3c
Compare
chrislopresto
added a commit
that referenced
this pull request
Mar 3, 2016
add bower dependencies to parent project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.