Bug - banks of non-equal sizes seem to have issues addressing patches

[christofmuc]

The bank definition right now:

return [{"bank": 0, "name": "RAM", "size": 40, "type": "Patch", "isROM": False },
            {"bank": 1, "name": "ROM", "size": 40+19, "type": "Patch", "isROM": True }]

That'll be 99 patches. 40 RAM and 59 ROM patches. Maybe there is a difference between Pulse 1 and Pulse 2?

Hex 27 = 39, so the first bank of 40 is retrieved ok, but then it starts the second bank at 3b, which is 59. It looks like a bug where it is using the bank size of the second bank to determine the start of the second. It should use the size of the first bank of course.

Are these bank sizes correct for your Pulse?

Originally posted by @christofmuc in #244

[christofmuc]

I think I found a fix, will be part of the next release.

[christofmuc]

Fixed with 2.5.3 today.