Optimise vi detection logic and use internal macros and commands as much as possible
#321
Conversation
keks24
changed the title
vi detection logic and use internal macros and commands as much as possible
keks24
force-pushed
the
optimise_vi_detection_logic
branch
from
07781dd to
dd211c8
Compare
|
Hi @keks24, I certainly appreciate the attempts to clean things up, but unfortunately I believe this would be a regression around the handling of subprocesses (e.g. a git alias / subcommand that spawns vim). The use of More generally, while I definitely appreciate the attempts to clean things up and make things more efficient, I'm unlikely to merge a sweeping change like this to the core Vim detection logic. My primary goal these days is to keep things stable and a change like this would require a ton of testing (in addition to the more pointed concerns outlined above). With all that in mind, I'm going to close this now. |
|
I see! At least it is documented here and others might still have a use of it. :) -Keks |
|
Absolutely! And the nice thing is that this part is easily swappable by folks so they can grab it if they specifically looking for the efficiency gains 🙂 |
Resolves #300 and should also resolve #295.
This pull-request uses:
#{version}to determine thecurrent tmux version1Else clausesforif-shell2display-message -pto output the version inbash3printf,sortandheadto check, if thecurrent tmux versionis higher, than3.0. The last two commands come from the packagecoreutils, which has more portability, thanbc.videtection logic uses apseudo substring matchby substitutingg?(view|n?vim?x?)(diff)?$from#{pane_current_command}.4Also everything is refactored to use internal macros and commands as much as possible to cause less load and invoking less subshells.
I was not sure about the
vim-part, but left a comment there with a snippet, which could be used.I adapted everything by logic and tested only certain parts of the plugin.
-Ramon
1
See
CHANGES FROM 2.3 TO 2.4, 20 April 2017https://github.com/tmux/tmux/blob/master/CHANGES
2
See
CHANGES FROM 1.5 TO 1.6, 23 January 2012https://github.com/tmux/tmux/blob/master/CHANGES
3
See
CHANGES FROM 1.1 TO 1.2, 10 March 2010https://github.com/tmux/tmux/blob/master/CHANGES
4
See
CHANGES FROM 2.1 TO 2.2, 10 April 2016https://github.com/tmux/tmux/blob/master/CHANGES