-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update is_vim
detection logic for tmux 3.2
#300
Conversation
Users upgrading to tmux 3.2 have been reporting issues with using the plugin, specifically that it would "freeze" their terminal for 30+ seconds. @kidonchu kindly provided an updated version of the `is_vim` check that seems to resolve the issue, so this PR updates the README and TPM script to use that version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for the fix! Tested with tmux next-3.3 and Neovim 0.5.
@dkarter thanks for the note! I'm also looking to confirm if this version of the snippet is reasonably backwards compatible, so hoping to hear from folks on tmux < 3.2 to validate that, so will likely need to keep this open for a bit. |
👋 Hello! So I gave this a shot on my setup with tmux 3.2, but I think the issue is still there.
With this plus the typical vim keybindings, it seems to skip over vim splits and goes directly to changing tmux panes. EDIT: Turns out fig was causing some issue where it modified the results from |
|
This doesn't work for me on Fedora 34 (using ps from procps-ng 3.3.17), but passing |
I think this approach #295 (comment) should fix incompatibility with Fig |
Users upgrading to tmux 3.2 have been reporting issues with using the
plugin, specifically that it would "freeze" their terminal for 30+
seconds.
@kidonchu kindly provided an updated version of the
is_vim
check thatseems to resolve the issue, so this PR updates the README and TPM script
to use that version.