Support z2m devices with / in 'friendly name'

[duvholt]

All my zigbee2mqtt devices use the namespace convention described here:
https://www.zigbee2mqtt.io/guide/usage/mqtt_topics_and_messages.html#zigbee2mqtt-friendly-name

This doesn't work in Bifrost as it ignores all device messages with a /. I've therefore been using a forked version where I just removed that check until I could investigate how this could be properly fixed.

Initially I thought this would require handling the weird edge cases with device1/set/attribute described here:
https://www.zigbee2mqtt.io/guide/usage/mqtt_topics_and_messages.html#zigbee2mqtt-friendly-name-set
But that's not relevant as all those messages are only sent to the websocket server and it seems like the only case we really need to handle is availability messages.

At least it looks like that's what the z2m frontend does:
https://github.com/nurikk/zigbee2mqtt-frontend/blob/25d88e716e4313e0643a48f32575974c0f4d1a98/src/ws-client.ts#L298-L304

[duvholt]

Just saw that there is another edge case with device1/action from looking at the gradient PR (and verifying with a hue dimmer). Doesn't look like that is documented in the z2m MQTT section and I suspect the z2m frontend doesn't really handle them correctly either.

[duvholt]

Did some more digging and there's also this weird wildcard: https://github.com/Koenkk/zigbee2mqtt/blob/c586df82429546fba56ab10b579bf225bb33ebb2/lib/extension/homeassistant.ts#L1277

Looks like it was implemented for a pretty specific use case, but I'm not sure how that message is supposed to be handled.

Other than that it looks like availability and action are the only exceptions.

[chrivers]

Great work! And nice analysis. I completely agree with your review.

Yes, unfortunately the z2m design is a bit of a mess in this respect. There is no perfect solution, except maybe avoiding / in device names 😅

Since the next check in the code checks that the name exists in our device map, the worst case of this change should be that users see a number of spurious warnings in the log.

Not great, but not fatal - and it only happens in case we've both missed something.

So let's do this 👍 And thank you for another good contribution :)