Show a loading state in between URQL states #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AP-3675 Loading state when switching story
We should show some kind of loading UI while the GQL query fetches the next story. |
weeksling
approved these changes
Sep 20, 2023
weeksling
approved these changes
Sep 20, 2023
Co-authored-by: Matthew Weeks <[email protected]>
…tate-when-switching-story
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce the problem, turn on network shaping to slow down your internet and switch stories. Rather than seeing the old story you should see a spinner while you wait:
Unfortunately there's no good way to simulate this behaviour in SB that I could come up with.
📦 Published PR as canary version:
0.0.91--canary.104.2a6ea41.0✨ Test out this PR locally via: