Fix issue with switching build without changing story #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In terms of replacing the selectedBuild with the lastBuildOnBranch and switching selectedBuilId
tmeasday
commented
Oct 12, 2023
ghengeveld
approved these changes
Oct 26, 2023
tmeasday
merged commit 339125d
into
tom/ap-3703-auto-switch-to-latest-if-story-is-on-latest-build-but-not-on
|
For me it's less about the state management (the file that transitions is pretty simple really), and more about how to test it. Unit tests are better than nothing but don't really cut it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping from #124
We had a bug where it automatically switched you to the new build when you already had a selected build as soon as you captured a new story. The specified behaviour was that it should "hold" until you opt-in (by clicking the header) or change story.
This ensures that (and adds a story that tests the changing story part actually works)...
To QA:
📦 Published PR as canary version:
0.0.110--canary.130.339125d.0✨ Test out this PR locally via: