Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to MSW 2.0 #136

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Upgrade to MSW 2.0 #136

merged 2 commits into from
Oct 30, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Oct 23, 2023 •
edited by tmeasday
Loading

Uses a modified version of msw-storybook-addon for now, until it's been updated to support MSW 2.0.

📦 Published PR as canary version: 0.0.110--canary.136.3023bab.0

✨ Test out this PR locally via:

npm install @chromaui/[email protected]
# or 
yarn add @chromaui/[email protected]

tmeasday
tmeasday approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghengeveld ghengeveld merged commit 9047fb6 into main Oct 30, 2023
@ghengeveld ghengeveld deleted the upgrade-msw branch October 30, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@yannbf yannbf Awaiting requested review from yannbf

@weeksling weeksling Awaiting requested review from weeksling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghengeveld @tmeasday @yannbf