Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust UI to Support Dark Mode #179

Merged
merged 30 commits into from
Feb 14, 2024
Merged

Adjust UI to Support Dark Mode #179

merged 30 commits into from
Feb 14, 2024

Conversation

thafryer
Copy link
Member

@thafryer thafryer commented Feb 6, 2024 •
edited by tmeasday
Loading

📦 Published PR as canary version: 1.1.8--canary.179.29b0d8c.0

✨ Test out this PR locally via:

npm install @chromatic-com/[email protected]
# or 
yarn add @chromatic-com/[email protected]

@thafryer thafryer force-pushed the dark-mode-adjustments branch from 7ab984a to be6704c Compare February 6, 2024 22:01
thafryer and others added 22 commits February 6, 2024 16:51
@thafryer
Adjust UI to Support Dark Mode
385705b
@domyen
Fine tune UI layout
2efb7d0
@domyen
Add ellipses to build progress (removed hardcoded eliipses)
9b3b339
@domyen
Increase text contrast light mode
2f1208d
@domyen
Minor tweak
fb9957c
@domyen
Style pre snippets
a998ab0
@domyen
Fixes and tweaks
e383672
@domyen
Fine tune SnapshotImage hover state
2aa292e
@domyen
Spacing tweaks
80a7351
@domyen
Fine tune more styles
84fe564
@domyen
More layout and style fine tuning
0581ac2
@domyen
Minor tweaks for capitalization and spacing
102723f
@domyen
Fix: consistent footer borderTop
7d4c83c
@domyen
Use the universal appBorderColor for dark mode borders instead of che…
0d906c6 
…cking for themes
@domyen
Fix double border issue in layout
27b15f7
@domyen
Merge branch 'main' into dark-mode-adjustments
9f0fd9b
@domyen
Section: remove last prop to reconcile how we add borders
ca800c2
@domyen
Remove border from Eyebrow
57a015c
@domyen
Fix regressions
542b6c2
@domyen
Minor copy updates
8e26ba1 
https://linear.app/chromaui/issue/AP-3883/visual-tests-design-qa
@domyen
Fix error message placement
a972048
@domyen
Align messages and styles, fix a hardcoded message that was wrong
ccb27f2
@domyen domyen requested a review from ghengeveld February 13, 2024 12:14
ghengeveld
ghengeveld approved these changes Feb 13, 2024
View reviewed changes
src/components/ModeSelector.tsx Outdated Show resolved Hide resolved
src/components/design-system/tooltip/ListItem.tsx Outdated Show resolved Hide resolved
thafryer
thafryer commented Feb 13, 2024
View reviewed changes
Copy link
Member Author

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few notes

src/components/BrowserSelector.tsx Outdated Show resolved Hide resolved
src/components/ModeSelector.tsx Outdated Show resolved Hide resolved
@domyen domyen merged commit 2e69514 into main Feb 14, 2024
6 checks passed
@domyen domyen deleted the dark-mode-adjustments branch February 14, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghengeveld ghengeveld ghengeveld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thafryer @ghengeveld @domyen