Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull screen container Section into Screen component #185

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Pull screen container Section into Screen component #185

merged 2 commits into from
Feb 11, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Feb 9, 2024 •
edited by tmeasday
Loading

This ensures that Screen contents always grow to fit vertical space, pushing the footer down.

Also this adds a story for the Screen component.

📦 Published PR as canary version: 1.1.6--canary.185.df41517.0

✨ Test out this PR locally via:

npm install @chromatic-com/[email protected]
# or 
yarn add @chromatic-com/[email protected]

andrewortwein
andrewortwein approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻👍🏻

@ghengeveld ghengeveld merged commit 474da25 into main Feb 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewortwein andrewortwein andrewortwein approved these changes

@thafryer thafryer thafryer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghengeveld @andrewortwein @thafryer