Don't show extra border when no config is available #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
approved these changes
Mar 14, 2024
andrewortwein
added
patch
andrewortwein
deleted the
andrew/ap-4364-vta-when-theres-no-config-file-the-state-looks-weird
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top "Configuration" section has a bottom border on it and the bottom "Uninstall" section has a top border on it, which is fine as long as there is something in the middle. This changes it so that the last item in the "middle" will have a bottom border, removing the top border from the "Uninstall" section. That way, when the middle is empty, there is no extra border.
I added a couple stories to make sure nothing changed when a config is actually present. None of the existing stories were capturing the bottom of the config.
Before:
After:
📦 Published PR as canary version:
1.2.20--canary.221.e9f4fdf.0✨ Test out this PR locally via: