Replace API polling with browser-native "online" status check #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
added
release
tevanoff
reviewed
Jun 27, 2024
ghengeveld
added
patch
tevanoff
reviewed
Jun 27, 2024
tevanoff
approved these changes
Jun 27, 2024
ghengeveld
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would poll the Chromatic API every 5 seconds to check for service availability (and internet connection). This floods our GraphQL API with needless requests, so we decided to remove that polling behavior.
To cover the most likely scenario of no internet connection, the browser
onlineandofflineevents are used to get notified of connection issues.📦 Published PR as canary version:
1.6.0--canary.326.58371ad.0✨ Test out this PR locally via: