Send mainPath and configDir on update success/failure #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeksling
approved these changes
Aug 29, 2023
| updateProject, | ||
| projectUpdatingFailed, | ||
| projectIdUpdated, | ||
| clearProjectIdUpdated, | ||
| ] = useProjectId(); | ||
| } = useProjectId(); |
There was a problem hiding this comment.
🔥 thank you for cleaning this up
weeksling
merged commit 792ed16
into
tom/ap-3485-display-the-project-token-and-project-id-to-the-user-in-case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping on #41
Send the
main.jslocation andconfigDirup on success/failure so we can incorporate it into the UIs.To QA:
Clear the selected options from
main.ts:addon-visual-tests/.storybook/main.ts
Line 40 in 1f7b002
Make
findConfigerror, select a project, check you see generic instructions (no specific main location)Make
updateMainerror, select a project, check you see instructions that includemain.tsMake it all work, select a project, check you see a message that includes
main.ts.📦 Published PR as canary version:
0.0.47--canary.53.792ed16.0✨ Test out this PR locally via: