I18n js fixes for lodash changes. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JDutil Hi, I had the same lodash reference problem. (fixed at this commit 7d9b5c7) I think this is webpacker config issue ( Actually, webpack config. ) |
|
@suzan2go interesting but I just tried that solution, and I still needed to apply these lodash changes to fix my compilation errors for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the latest i18n-js and webpacker 2 these changes are required for compatibility.
See also #2 & #3 which this resolves as well using #2 solution. Would be better to merge #2 before this PR for their credit I was too lazy to cherry-pick it.