[receiver/statsdreceiver] Add support for parsing dogstatsd multi value lines #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
maybelle
changed the title
vdarulis
reviewed
Dec 10, 2024
vdarulis
approved these changes
Dec 10, 2024
vdarulis
reviewed
Dec 10, 2024
robskillington
commented
Dec 11, 2024
| return res, nil | ||
| } | ||
|
|
||
| func (i *statsDMetricIter) ForEachValue(f func(m statsDMetric)) error { |
There was a problem hiding this comment.
nit: Maybe add a reason why both All and ForEachValue exist? (call out that foreachvalue avoids heap allocs?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dogstatsd v1.1 protocol allows specifying multiple values in a single datagram. This adds support for multiple values, converting them into multiple metrics with a single value each.
Testing
Added unit tests coverage for parsing multiple values
Documentation
None added