Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc comment to lib.rs: Conversion from and to EPOCH timestamps #185

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Add doc comment to lib.rs: Conversion from and to EPOCH timestamps #185

merged 1 commit into from
Sep 27, 2017

Conversation

kosta
Copy link

@kosta kosta commented Sep 4, 2017

This might fix #88

@kosta
Copy link
Author

kosta commented Sep 18, 2017

Did you get a chace to take a look? :)

@quodlibetor
Copy link
Contributor

Sorry I just got back from travels. This looks great, thanks!

@quodlibetor quodlibetor merged commit b3adf05 into chronotope:master Sep 27, 2017
@kosta
Copy link
Author

kosta commented Aug 23, 2018

I noticed it's been a year and a few releases since this got merged, but it still doesn't show up in the Readme.md (it's on docs.rs, though).

Maybe a make readme is missing?

Shall I run that and send a PR?

@quodlibetor
Copy link
Contributor

Oh wow, I didn't realize that that was necessary. There has now been enough drift that it's not just a matter of running make README.md, so I started adding something to CI using cargo readme to guarantee that the real readme is always up to date (like here) but got a little delayed. If you'd like to either fix it or add the automation that would be welcome, otherwise I'll get to it this weekend.

Thanks for pointing this out!

@kosta
Copy link
Author

kosta commented Aug 24, 2018

I tried cargo-readme, but first it complained about a missing key in Cargo.toml, then it generated an empty readme. So it didn't work for me (but I took no time to debug).

make readme works well, and it seems to me Readme and lib.rs doc comments didn't diverge much, I think it should only take a few minutes to clean this up. I hope I can do this either this weekend or on Monday.

quodlibetor added a commit to quodlibetor/rust-chrono that referenced this pull request Aug 25, 2018
@quodlibetor
Make README.md match lib.rs mod documentation
3b046b7 
And fail CI in the future if `make readme` isn't run when it is needed.

CC conversation in chronotope#185, where the README didn't get updated for a year after
lib.rs was improved.
@quodlibetor quodlibetor mentioned this pull request Aug 25, 2018
Merged
quodlibetor added a commit to quodlibetor/rust-chrono that referenced this pull request Aug 25, 2018
@quodlibetor
Make README.md match lib.rs mod documentation
dbb5836 
And fail CI in the future if `make readme` isn't run when it is needed.

CC conversation in chronotope#185, where the README didn't get updated for a year after
lib.rs was improved.
quodlibetor added a commit to quodlibetor/rust-chrono that referenced this pull request Aug 25, 2018
@quodlibetor
Make README.md match lib.rs mod documentation
2e563bc 
And fail CI in the future if `make readme` isn't run when it is needed.

CC conversation in chronotope#185, where the README didn't get updated for a year after
lib.rs was improved.
@kosta
Copy link
Author

kosta commented Aug 29, 2018

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Easy way to convert timestamp to UTC object?
2 participants
@kosta @quodlibetor