Fix leading dimension check

* TPMLQT, GEMLQT: Revert check of ldv and correct docs * Add input parameter checks for LASWLQ * LAMSWLQ: Fix mixed up column count of rhs (n) and original matrix (m)
chrwarm · Apr 3, 2022 · c137eb1 · c137eb1
1 parent 11d3fa9
commit c137eb1
Show file tree

Hide file tree

Showing 20 changed files with 176 additions and 92 deletions.
diff --git a/SRC/cgemlqt.f b/SRC/cgemlqt.f
@@ -95,9 +95,7 @@
 *> \param[in] LDV
 *> \verbatim
 *>          LDV is INTEGER
-*>          The leading dimension of the array V.
-*>          If SIDE = 'L', M >= K >= 0;
-*>          if SIDE = 'R', N >= K >= 0.
+*>          The leading dimension of the array V. LDV >= max(1,K).
 *> \endverbatim
 *>
 *> \param[in] T
@@ -211,7 +209,7 @@ SUBROUTINE CGEMLQT( SIDE, TRANS, M, N, K, MB, V, LDV, T, LDT,
          INFO = -5
       ELSE IF( MB.LT.1 .OR. (MB.GT.K .AND. K.GT.0)) THEN
          INFO = -6
-      ELSE IF( LDV.LT.MAX( 1, Q ) ) THEN
+      ELSE IF( LDV.LT.MAX( 1, K ) ) THEN
           INFO = -8
       ELSE IF( LDT.LT.MB ) THEN
          INFO = -10

diff --git a/SRC/clamswlq.f b/SRC/clamswlq.f
@@ -56,7 +56,7 @@
 *> \param[in] N
 *> \verbatim
 *>          N is INTEGER
-*>          The number of columns of the matrix C. N >= M.
+*>          The number of columns of the matrix C. N >= 0.
 *> \endverbatim
 *>
 *> \param[in] K
@@ -94,9 +94,7 @@
 *> \param[in] LDA
 *> \verbatim
 *>          LDA is INTEGER
-*>          The leading dimension of the array A.
-*>          If SIDE = 'L', LDA >= max(1,M);
-*>          if SIDE = 'R', LDA >= max(1,N).
+*>          The leading dimension of the array A. LDA => max(1,K).
 *> \endverbatim
 *>
 *> \param[in] T
@@ -213,7 +211,7 @@ SUBROUTINE CLAMSWLQ( SIDE, TRANS, M, N, K, MB, NB, A, LDA, T,
 *     ..
 *     .. Local Scalars ..
       LOGICAL    LEFT, RIGHT, TRAN, NOTRAN, LQUERY
-      INTEGER    I, II, KK, LW, CTR, Q
+      INTEGER    I, II, KK, LW, CTR
 *     ..
 *     .. External Functions ..
       LOGICAL            LSAME
@@ -232,10 +230,8 @@ SUBROUTINE CLAMSWLQ( SIDE, TRANS, M, N, K, MB, NB, A, LDA, T,
       RIGHT   = LSAME( SIDE, 'R' )
       IF (LEFT) THEN
         LW = N * MB
-        Q = M
       ELSE
         LW = M * MB
-        Q = N
       END IF
 *
       INFO = 0
@@ -247,11 +243,11 @@ SUBROUTINE CLAMSWLQ( SIDE, TRANS, M, N, K, MB, NB, A, LDA, T,
         INFO = -5
       ELSE IF( M.LT.K ) THEN
         INFO = -3
-      ELSE IF( N.LT.M ) THEN
+      ELSE IF( N.LT.0 ) THEN
         INFO = -4
       ELSE IF( K.LT.MB .OR. MB.LT.1) THEN
         INFO = -6
-      ELSE IF( LDA.LT.MAX( 1, Q ) ) THEN
+      ELSE IF( LDA.LT.MAX( 1, K ) ) THEN
         INFO = -9
       ELSE IF( LDT.LT.MAX( 1, MB) ) THEN
         INFO = -11

diff --git a/SRC/claswlq.f b/SRC/claswlq.f
@@ -60,7 +60,7 @@
 *> \verbatim
 *>          NB is INTEGER
 *>          The column block size to be used in the blocked QR.
-*>          NB > M.
+*>          NB > 0.
 *> \endverbatim
 *>
 *> \param[in,out] A
@@ -206,10 +206,10 @@ SUBROUTINE CLASWLQ( M, N, MB, NB, A, LDA, T, LDT, WORK, LWORK,
         INFO = -2
       ELSE IF( MB.LT.1 .OR. ( MB.GT.M .AND. M.GT.0 )) THEN
         INFO = -3
-      ELSE IF( NB.LE.M ) THEN
+      ELSE IF( NB.LE.0 ) THEN
         INFO = -4
       ELSE IF( LDA.LT.MAX( 1, M ) ) THEN
-        INFO = -5
+        INFO = -6
       ELSE IF( LDT.LT.MB ) THEN
         INFO = -8
       ELSE IF( ( LWORK.LT.M*MB) .AND. (.NOT.LQUERY) ) THEN

diff --git a/SRC/ctpmlqt.f b/SRC/ctpmlqt.f
@@ -88,9 +88,7 @@
 *> \param[in] LDV
 *> \verbatim
 *>          LDV is INTEGER
-*>          The leading dimension of the array V.
-*>          If SIDE = 'L', LDV >= max(1,M);
-*>          if SIDE = 'R', LDV >= max(1,N).
+*>          The leading dimension of the array V. LDV >= K.
 *> \endverbatim
 *>
 *> \param[in] T
@@ -217,7 +215,7 @@ SUBROUTINE CTPMLQT( SIDE, TRANS, M, N, K, L, MB, V, LDV, T, LDT,
 *     ..
 *     .. Local Scalars ..
       LOGICAL            LEFT, RIGHT, TRAN, NOTRAN
-      INTEGER            I, IB, NB, LB, KF, LDAQ, LDVQ
+      INTEGER            I, IB, NB, LB, KF, LDAQ
 *     ..
 *     .. External Functions ..
       LOGICAL            LSAME
@@ -240,10 +238,8 @@ SUBROUTINE CTPMLQT( SIDE, TRANS, M, N, K, L, MB, V, LDV, T, LDT,
       NOTRAN = LSAME( TRANS, 'N' )
 *
       IF ( LEFT ) THEN
-         LDVQ = MAX( 1, M )
          LDAQ = MAX( 1, K )
       ELSE IF ( RIGHT ) THEN
-         LDVQ = MAX( 1, N )
          LDAQ = MAX( 1, M )
       END IF
       IF( .NOT.LEFT .AND. .NOT.RIGHT ) THEN
@@ -260,7 +256,7 @@ SUBROUTINE CTPMLQT( SIDE, TRANS, M, N, K, L, MB, V, LDV, T, LDT,
          INFO = -6
       ELSE IF( MB.LT.1 .OR. (MB.GT.K .AND. K.GT.0) ) THEN
          INFO = -7
-      ELSE IF( LDV.LT.LDVQ ) THEN
+      ELSE IF( LDV.LT.K ) THEN
          INFO = -9
       ELSE IF( LDT.LT.MB ) THEN
          INFO = -11

diff --git a/SRC/dgemlqt.f b/SRC/dgemlqt.f
@@ -110,9 +110,7 @@
 *> \param[in] LDV
 *> \verbatim
 *>          LDV is INTEGER
-*>          The leading dimension of the array V.
-*>          If SIDE = 'L', LDV >= max(1,M);
-*>          if SIDE = 'R', LDV >= max(1,N).
+*>          The leading dimension of the array V.  LDV >= max(1,K).
 *> \endverbatim
 *>
 *> \param[in] T
@@ -226,7 +224,7 @@ SUBROUTINE DGEMLQT( SIDE, TRANS, M, N, K, MB, V, LDV, T, LDT,
          INFO = -5
       ELSE IF( MB.LT.1 .OR. (MB.GT.K .AND. K.GT.0)) THEN
          INFO = -6
-      ELSE IF( LDV.LT.MAX( 1, Q ) ) THEN
+      ELSE IF( LDV.LT.MAX( 1, K ) ) THEN
           INFO = -8
       ELSE IF( LDT.LT.MB ) THEN
          INFO = -10

diff --git a/SRC/dlamswlq.f b/SRC/dlamswlq.f
@@ -56,7 +56,7 @@
 *> \param[in] N
 *> \verbatim
 *>          N is INTEGER
-*>          The number of columns of the matrix C. N >= M.
+*>          The number of columns of the matrix C. N >= 0.
 *> \endverbatim
 *>
 *> \param[in] K
@@ -94,9 +94,7 @@
 *> \param[in] LDA
 *> \verbatim
 *>          LDA is INTEGER
-*>          The leading dimension of the array A.
-*>          If SIDE = 'L', LDA >= max(1,M);
-*>          if SIDE = 'R', LDA >= max(1,N).
+*>          The leading dimension of the array A. LDA >= max(1,K).
 *> \endverbatim
 *>
 *> \param[in] T
@@ -213,7 +211,7 @@ SUBROUTINE DLAMSWLQ( SIDE, TRANS, M, N, K, MB, NB, A, LDA, T,
 *     ..
 *     .. Local Scalars ..
       LOGICAL    LEFT, RIGHT, TRAN, NOTRAN, LQUERY
-      INTEGER    I, II, KK, CTR, LW, Q
+      INTEGER    I, II, KK, CTR, LW
 *     ..
 *     .. External Functions ..
       LOGICAL            LSAME
@@ -232,10 +230,8 @@ SUBROUTINE DLAMSWLQ( SIDE, TRANS, M, N, K, MB, NB, A, LDA, T,
       RIGHT   = LSAME( SIDE, 'R' )
       IF (LEFT) THEN
         LW = N * MB
-        Q = M
       ELSE
         LW = M * MB
-        Q = N
       END IF
 *
       INFO = 0
@@ -247,11 +243,11 @@ SUBROUTINE DLAMSWLQ( SIDE, TRANS, M, N, K, MB, NB, A, LDA, T,
         INFO = -5
       ELSE IF( M.LT.K ) THEN
         INFO = -3
-      ELSE IF( N.LT.M ) THEN
+      ELSE IF( N.LT.0 ) THEN
         INFO = -4
       ELSE IF( K.LT.MB .OR. MB.LT.1) THEN
         INFO = -6
-      ELSE IF( LDA.LT.MAX( 1, Q ) ) THEN
+      ELSE IF( LDA.LT.MAX( 1, K ) ) THEN
         INFO = -9
       ELSE IF( LDT.LT.MAX( 1, MB) ) THEN
         INFO = -11

diff --git a/SRC/dlaswlq.f b/SRC/dlaswlq.f
@@ -60,7 +60,7 @@
 *> \verbatim
 *>          NB is INTEGER
 *>          The column block size to be used in the blocked QR.
-*>          NB > M.
+*>          NB > 0.
 *> \endverbatim
 *>
 *> \param[in,out] A
@@ -202,10 +202,10 @@ SUBROUTINE DLASWLQ( M, N, MB, NB, A, LDA, T, LDT, WORK, LWORK,
         INFO = -2
       ELSE IF( MB.LT.1 .OR. ( MB.GT.M .AND. M.GT.0 )) THEN
         INFO = -3
-      ELSE IF( NB.LE.M ) THEN
+      ELSE IF( NB.LT.0 ) THEN
         INFO = -4
       ELSE IF( LDA.LT.MAX( 1, M ) ) THEN
-        INFO = -5
+        INFO = -6
       ELSE IF( LDT.LT.MB ) THEN
         INFO = -8
       ELSE IF( ( LWORK.LT.M*MB) .AND. (.NOT.LQUERY) ) THEN

diff --git a/SRC/dtpmlqt.f b/SRC/dtpmlqt.f
@@ -103,9 +103,7 @@
 *> \param[in] LDV
 *> \verbatim
 *>          LDV is INTEGER
-*>          The leading dimension of the array V.
-*>          If SIDE = 'L', LDV >= max(1,M);
-*>          if SIDE = 'R', LDV >= max(1,N).
+*>          The leading dimension of the array V. LDV >= K.
 *> \endverbatim
 *>
 *> \param[in] T
@@ -232,7 +230,7 @@ SUBROUTINE DTPMLQT( SIDE, TRANS, M, N, K, L, MB, V, LDV, T, LDT,
 *     ..
 *     .. Local Scalars ..
       LOGICAL            LEFT, RIGHT, TRAN, NOTRAN
-      INTEGER            I, IB, NB, LB, KF, LDAQ, LDVQ
+      INTEGER            I, IB, NB, LB, KF, LDAQ
 *     ..
 *     .. External Functions ..
       LOGICAL            LSAME
@@ -255,10 +253,8 @@ SUBROUTINE DTPMLQT( SIDE, TRANS, M, N, K, L, MB, V, LDV, T, LDT,
       NOTRAN = LSAME( TRANS, 'N' )
 *
       IF ( LEFT ) THEN
-         LDVQ = MAX( 1, M )
          LDAQ = MAX( 1, K )
       ELSE IF ( RIGHT ) THEN
-         LDVQ = MAX( 1, N )
          LDAQ = MAX( 1, M )
       END IF
       IF( .NOT.LEFT .AND. .NOT.RIGHT ) THEN
@@ -275,7 +271,7 @@ SUBROUTINE DTPMLQT( SIDE, TRANS, M, N, K, L, MB, V, LDV, T, LDT,
          INFO = -6
       ELSE IF( MB.LT.1 .OR. (MB.GT.K .AND. K.GT.0) ) THEN
          INFO = -7
-      ELSE IF( LDV.LT.LDVQ ) THEN
+      ELSE IF( LDV.LT.K ) THEN
          INFO = -9
       ELSE IF( LDT.LT.MB ) THEN
          INFO = -11

diff --git a/SRC/sgemlqt.f b/SRC/sgemlqt.f
@@ -95,9 +95,7 @@
 *> \param[in] LDV
 *> \verbatim
 *>          LDV is INTEGER
-*>          The leading dimension of the array V.
-*>          If SIDE = 'L', LDV >= max(1,M);
-*>          if SIDE = 'R', LDV >= max(1,N).
+*>          The leading dimension of the array V. LDV >= max(1,K).
 *> \endverbatim
 *>
 *> \param[in] T
@@ -211,7 +209,7 @@ SUBROUTINE SGEMLQT( SIDE, TRANS, M, N, K, MB, V, LDV, T, LDT,
          INFO = -5
       ELSE IF( MB.LT.1 .OR. (MB.GT.K .AND. K.GT.0)) THEN
          INFO = -6
-      ELSE IF( LDV.LT.MAX( 1, Q ) ) THEN
+      ELSE IF( LDV.LT.MAX( 1, K ) ) THEN
           INFO = -8
       ELSE IF( LDT.LT.MB ) THEN
          INFO = -10

diff --git a/SRC/slamswlq.f b/SRC/slamswlq.f
@@ -56,7 +56,7 @@
 *> \param[in] N
 *> \verbatim
 *>          N is INTEGER
-*>          The number of columns of the matrix C. N >= M.
+*>          The number of columns of the matrix C. N >= 0.
 *> \endverbatim
 *>
 *> \param[in] K
@@ -94,9 +94,7 @@
 *> \param[in] LDA
 *> \verbatim
 *>          LDA is INTEGER
-*>          The leading dimension of the array A.
-*>          If SIDE = 'L', LDA >= max(1,M);
-*>          if SIDE = 'R', LDA >= max(1,N).
+*>          The leading dimension of the array A. LDA >= max(1,K).
 *> \endverbatim
 *>
 *> \param[in] T
@@ -213,7 +211,7 @@ SUBROUTINE SLAMSWLQ( SIDE, TRANS, M, N, K, MB, NB, A, LDA, T,
 *     ..
 *     .. Local Scalars ..
       LOGICAL    LEFT, RIGHT, TRAN, NOTRAN, LQUERY
-      INTEGER    I, II, KK, LW, CTR, Q
+      INTEGER    I, II, KK, LW, CTR
 *     ..
 *     .. External Functions ..
       LOGICAL            LSAME
@@ -232,10 +230,8 @@ SUBROUTINE SLAMSWLQ( SIDE, TRANS, M, N, K, MB, NB, A, LDA, T,
       RIGHT   = LSAME( SIDE, 'R' )
       IF (LEFT) THEN
         LW = N * MB
-        Q = M
       ELSE
         LW = M * MB
-        Q = N
       END IF
 *
       INFO = 0
@@ -247,11 +243,11 @@ SUBROUTINE SLAMSWLQ( SIDE, TRANS, M, N, K, MB, NB, A, LDA, T,
         INFO = -5
       ELSE IF( M.LT.K ) THEN
         INFO = -3
-      ELSE IF( N.LT.M ) THEN
+      ELSE IF( N.LT.0 ) THEN
         INFO = -4
       ELSE IF( K.LT.MB .OR. MB.LT.1) THEN
         INFO = -6
-      ELSE IF( LDA.LT.MAX( 1, Q ) ) THEN
+      ELSE IF( LDA.LT.MAX( 1, K ) ) THEN
         INFO = -9
       ELSE IF( LDT.LT.MAX( 1, MB) ) THEN
         INFO = -11

diff --git a/SRC/slaswlq.f b/SRC/slaswlq.f
@@ -60,7 +60,7 @@
 *> \verbatim
 *>          NB is INTEGER
 *>          The column block size to be used in the blocked QR.
-*>          NB > M.
+*>          NB > 0.
 *> \endverbatim
 *>
 *> \param[in,out] A
@@ -202,10 +202,10 @@ SUBROUTINE SLASWLQ( M, N, MB, NB, A, LDA, T, LDT, WORK, LWORK,
         INFO = -2
       ELSE IF( MB.LT.1 .OR. ( MB.GT.M .AND. M.GT.0 )) THEN
         INFO = -3
-      ELSE IF( NB.LE.M ) THEN
+      ELSE IF( NB.LE.0 ) THEN
         INFO = -4
       ELSE IF( LDA.LT.MAX( 1, M ) ) THEN
-        INFO = -5
+        INFO = -6
       ELSE IF( LDT.LT.MB ) THEN
         INFO = -8
       ELSE IF( ( LWORK.LT.M*MB) .AND. (.NOT.LQUERY) ) THEN