[#98] changed all formatting functions so they accept a type that implements Display

src/config/schema.rs

@@ -64,14 +64,14 @@ impl Config {
         let expanded_store_directory = shellexpand::full(&self.store_directory);
 
         let store_directory = match expanded_store_directory {
-            Err(e) => err::abort_with(&e.to_string()),
+            Err(e) => err::abort_with(e),
             Ok(cow_path) => PathBuf::from(cow_path.into_owned()),
         };
 
         let has_store_directory = store_directory.as_path().is_dir();
 
         if !has_store_directory {
-            err::abort_with(&format!(
+            err::abort_with(format!(
                 "Specified directory for storing tools doesn't exist: {}",
                 store_directory.display()
             ));

src/config/toml.rs

@@ -31,10 +31,10 @@ pub fn with_parsed_file<F: FnOnce(Config)>(config_path: PathBuf, on_success: F)
             on_success(config);
         }
         Err(e) => {
-            err::abort_with(&format!(
+            err::abort_with(format!(
                 "Error parsing configuration at path {}: {}",
                 config_path.display(),
-                e.to_string()
+                e
             ));
         }
     }

src/infra/err.rs

@@ -1,7 +1,9 @@
+use std::fmt::Display;
 use std::process;
 
 /// Print an error message and exit with code 1
-pub fn abort_with(err_msg: &str) -> ! {
+/// This function can take in any type that implements the [`Display`] trait
+pub fn abort_with<Message: Display>(err_msg: Message) -> ! {
     eprintln!(
         r#"Aborting 'tool-sync' with error:
 
@@ -13,7 +15,8 @@ pub fn abort_with(err_msg: &str) -> ! {
 }
 
 /// Print an error message, suggesting opening an issue and exit with code 1
-pub fn abort_suggest_issue(err_msg: &str) -> ! {
+/// This function can take in any type that implements the [`Display`] trait
+pub fn abort_suggest_issue<Message: Display>(err_msg: Message) -> ! {
     eprintln!(
         r#"Aborting 'tool-sync' with error:
 
@@ -31,7 +34,8 @@ this issue:
 }
 
 /// Print just the message and exit
-pub fn abort(err_msg: &str) -> ! {
+/// This function can take in any type that implements the [`Display`] trait
+pub fn abort<Message: Display>(err_msg: Message) -> ! {
     eprintln!("{}", err_msg);
     process::exit(1);
 }

src/install.rs

@@ -27,6 +27,6 @@ Supported tools:
 {tools}"#
         );
 
-        err::abort(&exit_message);
+        err::abort(exit_message);
     }
 }

src/sync/install.rs

@@ -28,7 +28,7 @@ impl<'a> Installer<'a> {
         let tmp_dir = TempDir::new("tool-sync");
         match tmp_dir {
             Err(e) => {
-                err::abort_suggest_issue(&format!("Error creating temporary directory: {}", e));
+                err::abort_suggest_issue(format!("Error creating temporary directory: {}", e));
             }
             Ok(tmp_dir) => Installer {
                 store_directory,

src/sync/prefetch.rs

@@ -1,6 +1,8 @@
 use console::{style, Emoji};
 use indicatif::{HumanBytes, ProgressBar, ProgressStyle};
+
 use std::collections::BTreeMap;
+use std::fmt::Display;
 
 use super::configure::configure_tool;
 use crate::config::schema::ConfigAsset;
@@ -36,12 +38,14 @@ impl PrefetchProgress {
         }
     }
 
-    fn expected_err_msg(&self, tool_name: &str, msg: &str) {
+    /// This method can take in any type that implements the [`Display`] trait
+    fn expected_err_msg<Message: Display>(&self, tool_name: &str, msg: &Message) {
         let tool = format!("{}", style(tool_name).cyan().bold());
         self.pb.println(format!("{} {} {}", ERROR, tool, msg))
     }
 
-    fn unexpected_err_msg(&self, tool_name: &str, msg: &str) {
+    /// This method can take in any type that implements the [`Display`] trait
+    fn unexpected_err_msg<Message: Display>(&self, tool_name: &str, msg: &Message) {
         let tool = format!("{}", style(tool_name).cyan().bold());
         let err_msg = format!(
             r#"{emoji} {tool} {msg}
@@ -106,7 +110,7 @@ fn prefetch_tool(
 
     match configure_tool(tool_name, config_asset) {
         Tool::Error(e) => {
-            prefetch_progress.expected_err_msg(tool_name, &e.to_string());
+            prefetch_progress.expected_err_msg(tool_name, &e);
             prefetch_progress.update_message(already_completed);
             None
         }
@@ -125,7 +129,7 @@ fn prefetch_tool(
                 }
                 Ok(release) => match tool_info.select_asset(&release.assets) {
                     Err(err) => {
-                        prefetch_progress.unexpected_err_msg(tool_name, &err.to_string());
+                        prefetch_progress.unexpected_err_msg(tool_name, &err);
                         prefetch_progress.update_message(already_completed);
                         None
                     }

src/sync/progress.rs

@@ -1,3 +1,5 @@
+use std::fmt::Display;
+
 use console::{style, Emoji};
 use indicatif::{MultiProgress, ProgressBar, ProgressStyle};
 
@@ -84,7 +86,14 @@ impl SyncProgress {
         pb.finish();
     }
 
-    pub fn failure(&self, pb: ProgressBar, tool_name: &str, tag: &str, err_msg: String) {
+    /// This method can take in any type that implements the [`Display`] trait
+    pub fn failure<Message: Display>(
+        &self,
+        pb: ProgressBar,
+        tool_name: &str,
+        tag: &str,
+        err_msg: Message,
+    ) {
         pb.set_prefix(self.fmt_prefix(FAILURE, tool_name, tag));
 
         let failure_msg = format!("{}", style(err_msg).red());