Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#73] adding .precommit yaml #79

Merged
merged 3 commits into from
Sep 10, 2022
Merged

Conversation

MitchellBerend
Copy link
Collaborator

This pr adds a .pre-commit-config.yaml to the repo so others can install a
pre-commit.

The options added are in the suggested list of the pre-commit project.

Additional tasks

  • Documentation for changes provided/changed
    - [ ] Tests added

@MitchellBerend
Copy link
Collaborator Author

There are quite a lot of files that don't pass the pre-commit checks that are defined in the current .pre-commit-config.yaml.
They are mostly whitespace and end-of-file newlines, should I add those changes to this pr as well?

@MitchellBerend MitchellBerend added documentation Improvements or additions to documentation CI ⚗️ dx labels Sep 10, 2022
@chshersh
Copy link
Owner

There are quite a lot of files that don't pass the pre-commit checks that are defined in the current .pre-commit-config.yaml.
They are mostly whitespace and end-of-file newlines, should I add those changes to this pr as well?

Go for it 👍🏻

@MitchellBerend MitchellBerend marked this pull request as ready for review September 10, 2022 16:12
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks terrific 🏆

@chshersh chshersh merged commit 4341cc7 into chshersh:main Sep 10, 2022
@MitchellBerend MitchellBerend deleted the pre-commit-file branch September 10, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI documentation Improvements or additions to documentation ⚗️ dx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants