Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#88] Replace custom display() method with std::fmt::Display trait implementation #99

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Conversation

zixuan-x
Copy link
Contributor

Resolves #88

Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat! 👏🏻

I have nothing to add, this was a pretty good refactoring 🙂

@@ -1,4 +1,4 @@
/// This file only holds the template that is used to generate a default .tools.toml.
/// This file only holds the template that is used to generate a default .tool.toml.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, apparently the documentation was wrong in many places 👀
Thanks again for fixing it!

@chshersh chshersh merged commit 52a3803 into chshersh:main Sep 19, 2022
@zixuan-x zixuan-x deleted the display branch September 19, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor custom 'display()' functions to use the 'Display' trait
2 participants