Quick Removal Of The Incorrect Russian Roulette. #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting rayDepth to 1 -> light cannot bounce off the ground, thus everything but the sky is black. Setting rayDepth to 2 -> light can bounce off of the ground/blocks, but cannot bounce off of anything else. Emitters do not work. Setting rayDepth to 3 -> hey look, torches give off light now! Setting rayDepth to 4 -> the start of indirect illumination from emitters...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1018 for motivation for this.
now:
Setting rayDepth to 1 -> light cannot bounce off the ground, thus everything but the sky is black.
Setting rayDepth to 2 -> light can bounce off of the ground/blocks, but cannot bounce off of anything else. Emitters do not work.
Setting rayDepth to 3 -> hey look, torches give off light now!
Setting rayDepth to 4 -> the start of indirect illumination from emitters...