-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing tags to be propagated for other events as well #180
base: master
Are you sure you want to change the base?
Conversation
Support for Windows-gnu with http://repo.msys2.org/mingw/x86_64/ Current versions supported are >= 10.0. LLVM_VERSION is at 9.0. Should we up the version to 10 at least? @chyh1990
|
e4e5705
to
1c6497b
Compare
What's the status of this PR? I really need this. @dchakrav-github @chyh1990 |
@yuhr I am using my forked version of this code here currently to unblock. There is also a pending change to serde_yaml crate that i am unable to release. Currently, there is a appveyor.yml that is failing to run when trying to fetch the correct LLVM/CLANG versions from a location (see build logs) that I am unable to fix. I would like to get this merged. @chyh1990 please let me know what you would need to merge thie change. |
Hi owners, Wanted to check with you if there is a way we can prioritize getting this PR merged? We are AWS CloudFormation team and our release for Guard 2.1 is blocked to be published on crates.io because we need this fix to be implemented in the crate for this repo. If there are any recommended changes that we'd need to do before we could merge it, please advise and we will work on them. Appreciate any guidance we could get. Thanks! Akshay |
This change is need to support dtolnay/serde-yaml#220. It provides the needed propagation of tags for
SequenceStart
andMappingStart
events. This allows consumers of these events usingMarkedEventReceiver
orEventReceiver
to take advantage of the tags to reason mapping.In addition to the usage for serde-yaml show above, a usage when dealing with AWS CloudFormation templates can be seen here.
Please note, this PR did not change the testing to also return events with tags contained as outline in issue #148.
Issues: dtolnay/serde-yaml#147, #147, I believe this also helps address #35 (need more verification here, but the examples provided are both implemented in dtolnay/serde-yaml#220 pull and the CloudFormation provided above)