Add support for generating Hubble metrics certificates #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chance Zibolski <[email protected]>
kaworu
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Patch LGTM, however we already have a lot of duplication, and adding two more certificates that way will introduce even more.
I think it's time to consider refactoring certgen to allow the configuration to drive certificate generation. I understand you're currently working on something unrelated and I'm not suggesting to do it as part of the metrics work, but we should kick off the discussion. @chancez what do you think?
|
@kaworu yeah, I think that would be ideal, but at the same time; at this point it would likely just be a lot of work for little gain. Adding new certs took like 5 minutes, even if it was pretty duplicated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on adding TLS support to hubble and cilium metrics servers, starting with Hubble. I've tested this locally in kind by installing cilium with a custom certain image using my branch https://github.com/cilium/cilium/tree/pr/chancez/hubble_metrics_mtls.