Add restart flag to config set and delete commands #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditighag
changed the title
jrajahalme
approved these changes
Apr 2, 2021
tklauser
requested changes
Apr 7, 2021
aditighag
force-pushed
the
pr/aditighag/setconfig-reset-flag
branch
from
588da1e to
3546c5f
Compare
tgraf
requested changes
Apr 13, 2021
|
I realized that we need to add the restart behavior to |
aditighag
force-pushed
the
pr/aditighag/setconfig-reset-flag
branch
from
3546c5f to
8cf61c6
Compare
aditighag
changed the title
aditighag
force-pushed
the
pr/aditighag/setconfig-reset-flag
branch
from
8cf61c6 to
0b31252
Compare
aditighag
force-pushed
the
pr/aditighag/setconfig-reset-flag
branch
from
0b31252 to
92a7763
Compare
After config map changes are made, Cilium pods need to be restarted for the changes to take effect. Currently, this is a manual step. Add a flag with default value to restart Cilium pods. Signed-off-by: Aditi Ghag <[email protected]>
aditighag
force-pushed
the
pr/aditighag/setconfig-reset-flag
branch
from
92a7763 to
7d5ecbb
Compare
EKS failures are due to resource unavailability issue. Edit : The changes are not related EKS platform, and connectivity tests on other two platforms have passed so I'm not restarting all the tests again. |
tgraf
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After setting config map changes, Cilium pods need to be restarted for the changes to take effect.
Currently, this is a manual step. Add a new flag to restart the pods by default.
Tested the changes on a local kind cluster.