Extract and generalize the sniffer logic used by encryption tests for easier reusability #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can retrieve whether debug logging is enabled to guard possible expensive operations to be performed only when debug logging is enabled. Signed-off-by: Marco Iorio <[email protected]>
As a preparatory step for the subsequent extraction of the sniffer logic into a separate package, let's start extracting the safeBuffer utility. The only difference is that the mutex is no longer embedded into, but an explicit field of lock.Buffer, as per best practices. Signed-off-by: Marco Iorio <[email protected]>
Let's extract this logic into a separate package, so that it can be easily reused by other connectivity tests in addition to the encryption ones. At this stage, no additional changes are introduced except for exporting the necessary types/methods and adapting the call sites. Signed-off-by: Marco Iorio <[email protected]>
Following the extraction of this logic into a separate package, let's also generalize it a bit, to improve its reusability in different contexts. While being there, let's also improve the error reporting, to simplify troubleshooting possible issues. Signed-off-by: Marco Iorio <[email protected]>
Signed-off-by: Marco Iorio <[email protected]>
Let's extract the definition of this filter into a separate package alongside the sniffer logic, so that it can be easily reused as well. Signed-off-by: Marco Iorio <[email protected]>
christarazi
approved these changes
Jan 19, 2024
gandro
approved these changes
Jan 22, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit by commit and refer to the individual commit messages for additional details. Most of the changes in this PR are due to moving code around, and are isolated in their own commits (second, third and sixth).