Store namespace and k8sClient in the command context #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tklauser what do you think about this change? simply exporting namespace and k8sClient fields doesn't work because it creates a circular dependency between https://github.com/cilium/cilium-cli/blob/pr/michi/majestic-ketchup/cli/cmd.go and https://github.com/cilium/cilium/blob/pr/michi/majestic-ketchup/pkg/cilium-cli/cmd/connectivity.go 💭 |
|
If this is the direction we do decide to go, I'd like to see typed getters for these. (I'm missing a lot of context though). |
tklauser
reviewed
Mar 12, 2024
Store namespace and k8sClient as command context values so that the connectivity package can access them from outside the cli package once it moves to cilium/cilium repo. Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/command-context
branch
from
b372485 to
f36e8f6
Compare
tklauser
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store namespace and k8sClient as command context values so that the connectivity package can access them from outside the cli package once it moves to cilium/cilium repo.
Ref: cilium/design-cfps#9