refactor: Move logging outside internal #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the logging package out of internal/ so that it can be imported from outside cilium/cilium-cli repo. This is useful for building the cilium CLI binary from cilium/cilium repo [^1]. [^1]: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <[email protected]>
asauber
requested changes
Mar 16, 2024
there is no |
asauber
approved these changes
Mar 17, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the logging package out of internal/ so that it can be imported from outside cilium/cilium-cli repo. This is useful for building the cilium CLI binary from cilium/cilium repo 1.
Footnotes
CFP-25694: Move cilium/cilium-cli code into cilium/cilium repository design-cfps#9 ↩