-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to pull LVH images directly from OCI repositories #133
Conversation
4165722
to
2217288
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
One thought I had was to add a manifest file in the images that describe what the OCI image contains (e.g., rootfs images, kernels, etc.). But until we have that, auto-detection is great.
Add support to pull LVH images directly from the commandline so that users who don't need to customize the image can directly pull the required images directly rather than having to run another script or manually pull & decompress the images locally. Example usage: $ lvh images pull quay.io/lvh-images/kind:5.4-main Signed-off-by: Joe Stringer <[email protected]>
These will be used by an upcoming commit to pull LVH images directly from the CLI. Signed-off-by: Joe Stringer <[email protected]>
Example usage: $ lvh run --image quay.io/lvh-images/kind:bpf-next-main Signed-off-by: Joe Stringer <[email protected]>
Signed-off-by: Joe Stringer <[email protected]>
Replace the open-coded image pull and decompression with native OCI image support directly in LVH. Signed-off-by: Joe Stringer <[email protected]>
2217288
to
bf87988
Compare
Yeah the autodetect is not entirely ideal since I did notice some docker images have multiple VM images inside. Autodetect is arbitrarily picking one. But then it also extracts every image, so if you know what you're doing then you can use the image pull and then subsequently explore the Another potential area for expansion is to add a similar functionality for kernels ( I fixed up the flag as you suggested, will merge. Thanks for the review! |
To adjust to the changes from cilium/little-vm-helper#133. Signed-off-by: Martynas Pumputis <[email protected]>
To adjust to the changes from cilium/little-vm-helper#133. Signed-off-by: Martynas Pumputis <[email protected]>
[ upstream commit ad7d792 ] To adjust to the changes from cilium/little-vm-helper#133. Signed-off-by: Martynas Pumputis <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
[ upstream commit ad7d792 ] To adjust to the changes from cilium/little-vm-helper#133. Signed-off-by: Martynas Pumputis <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
[ upstream commit ad7d792 ] To adjust to the changes from cilium/little-vm-helper#133. Signed-off-by: Martynas Pumputis <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
[ upstream commit ad7d792 ] To adjust to the changes from cilium/little-vm-helper#133. Signed-off-by: Martynas Pumputis <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
[ upstream commit ad7d792 ] To adjust to the changes from cilium/little-vm-helper#133. Signed-off-by: Martynas Pumputis <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
[ upstream commit ad7d792 ] To adjust to the changes from cilium/little-vm-helper#133. Signed-off-by: Martynas Pumputis <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
[ upstream commit ad7d792 ] To adjust to the changes from cilium/little-vm-helper#133. Signed-off-by: Martynas Pumputis <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
[ upstream commit ad7d792 ] To adjust to the changes from cilium/little-vm-helper#133. Signed-off-by: Martynas Pumputis <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
This PR adds support to directly pull VM images in the CLI so that the user
doesn't need to do this if they just want to reuse existing images that were
already built for the Cilium project.
The first command added is a direct replacement for the image pull script.
It pulls an image from the specified OCI repository and decompresses it
for local usage. Example usage:
The second command leverages the same underlying support in order to directly
run VM images from the OCI image. This removes the need for users to manually
pull it. Example usage: