Make cmapisrv-mock addresses configurable #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
force-pushed
the
pr/giorio94/cmapisrv-mock-random
branch
from
e4850e6 to
11bb066
Compare
|
Rebased onto main to fix conflict. |
learnitall
approved these changes
Jun 27, 2024
That's definitely a possibility. I haven't done that at the moment to avoid adding more parameters, considering that there's not much value in configuring the size of those CIDRs with the current implementation. Indeed, the IP of an endpoint is picked from the entire PodCIDR range, and not from the specific PodCIDR of the node. However, that's something we may want to consider in the future if this mechanism turns out to lead to unexpected behavior. |
So that it randomly picks either an IPv4 or an IPv6 address, rather than IPv6 only. Signed-off-by: Marco Iorio <[email protected]>
In order to shorten the signature of the functions initializing the mockers for the different resources, and simplify adding new parameters. Signed-off-by: Marco Iorio <[email protected]>
This will allow a subsequent commit to make the CIDRs configurable. Signed-off-by: Marco Iorio <[email protected]>
To allow configuring different ranges in case they overlap with other infrastructural addresses, and prevent breaking connectivity. Signed-off-by: Marco Iorio <[email protected]>
giorio94
force-pushed
the
pr/giorio94/cmapisrv-mock-random
branch
from
11bb066 to
89393c1
Compare
|
Rebased onto main to run the lint and build pipelines before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow configuring different ranges in case they overlap with other infrastructural addresses, and prevent breaking connectivity. Additionally, let's fix the endpoint mocking logic that incorrectly always picked IPv6 addresses when IPv6 was enabled.