Avoid requiring the latest Go toolchain patch version to build #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
added
area/ci
mtardy
force-pushed
the
pr/mtardy/drop-go-mod-latest-version
branch
from
cd23739 to
8f4d5a5
Compare
[ port of cilium/cilium@924df33 ] Nothing in the tree depends on newer patch releases of Go, so we can keep this to the first patch release of this series. Signed-off-by: Mahe Tardy <[email protected]>
[ port of cilium/cilium@91d7a49 ] The goal here is to allow developer toolchains to have more flexibility around the specific version of Go compared with the latest patch releases. Note that all of the real-world code and all tests will continue to be updated to use the latest Go versions, it's just the go.mod that will start to drift, since the code can actually compile with earlier versions of Go; we don't require specific patch versions based on the set of standard library features used in the code. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/drop-go-mod-latest-version
branch
from
8f4d5a5 to
85c2379
Compare
This was referenced Nov 13, 2023
lambdanis
approved these changes
Nov 13, 2023
mtardy
added a commit
that referenced
this pull request
Dec 6, 2023
This reverts commit dd5ddc2. This was a good idea but #1748 impacts this as we no longer update the patch version in the go.mod directive. Thus the CI is running outdated Go versions. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
added a commit
that referenced
this pull request
Dec 6, 2023
This reverts commit dd5ddc2. This was a good idea but #1748 impacts this as we no longer update the patch version in the go.mod directive. Thus the CI is running outdated Go versions. Signed-off-by: Mahe Tardy <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of cilium/cilium#28686. We are seeing issues in the CI as well https://github.com/cilium/tetragon/actions/runs/6853112156/job/18633190187?pr=1747.